Skip to content

Does not work with python 3.6 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 3 tasks
gabohc opened this issue Feb 9, 2023 · 4 comments
Closed
1 of 3 tasks

Does not work with python 3.6 #665

gabohc opened this issue Feb 9, 2023 · 4 comments
Labels
type: documentation

Comments

@gabohc
Copy link

gabohc commented Feb 9, 2023

Type

  • Content inaccurate
  • Content missing
  • Typo

URL

https://commitizen-tools.github.io/commitizen/

Description

According to the docs, it requires python 3.6 at minimum.

However, hooks.py uses from __future__ import annotations, which is not supported by python 3.6
@Lee-W
Copy link
Member

Lee-W commented Feb 11, 2023

@woile It seems I accidentally merged a branch that would break 3.6. I'm thinking of merging v3 and explicitly dropping 3.6 support

@woile
Copy link
Member

woile commented Feb 11, 2023

Agreed, py36 support was dropped officially, we should drop it and maybe next year also 3.7. I remember a discussion or PR to drop 3.6 somewhere, right?

@Lee-W
Copy link
Member

Lee-W commented Feb 11, 2023

Yep, if my memory serves me right, we decide to do so in v3. As this sounds like a breaking change to me. v3 might be a reasonable option

@jakob-keller jakob-keller mentioned this issue Mar 11, 2023
Merged
4 tasks
@woile
Copy link
Member

woile commented Apr 28, 2023

We no longer support python 3.6

@woile woile closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@woile @Lee-W @gabohc