Refactor getCacheCallback to directly use parent promise's resolve an… #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d reject, simplifying error handling and avoiding nested promises.
nadeem-cs
previously approved these changes
Jan 24, 2025
nadeem-cs
approved these changes
Jan 24, 2025
sunil-lakshman
added a commit
that referenced
this pull request
Jan 30, 2025
… parent promise's resolve an… (#272) * Refactor getCacheCallback to directly use parent promise's resolve an… (#271) * Refactor getCacheCallback to directly use parent promise's resolve and reject, simplifying error handling and avoiding nested promises. * Updated utils.js file * Fixed empty object error when API throw error * removed cheerio package as it had high vulnerability in latest update * update sanity reports files * version bump to 3.24.2 --------- Co-authored-by: harshitha.d <harshitha.d@contentstack.com> Co-authored-by: harshithad0703 <104908717+harshithad0703@users.noreply.github.com>
sunil-lakshman
added a commit
that referenced
this pull request
Jan 30, 2025
* DX | 27-01-2025 | Release (#269) (#276) * fix: added fix for updateasseturl for handling jrte within blocks * dropping isomorphic-fetch and node-fetch * version bumpt to 3.23.1 * removed commented lines * Updated error codes in testcases * fix: disable minification for improved debugging * fix: setting minimize to true for browser * verison bump * license update * Updated slack bolt and qs * version fixed * sanity update for dev11 --------- Co-authored-by: cs-raj <122264749+cs-raj@users.noreply.github.com> Co-authored-by: Vikram Kalta <vikramkalta@Vikrams-MacBook-Pro.local> Co-authored-by: Vikram Kalta <65945391+vkalta@users.noreply.github.com> Co-authored-by: harshitha.d <harshitha.d@contentstack.com> Co-authored-by: harshithad0703 <104908717+harshithad0703@users.noreply.github.com> * DX | 27-01-2025 | Release | Refactor getCacheCallback to directly use parent promise's resolve an… (#272) * Refactor getCacheCallback to directly use parent promise's resolve an… (#271) * Refactor getCacheCallback to directly use parent promise's resolve and reject, simplifying error handling and avoiding nested promises. * Updated utils.js file * Fixed empty object error when API throw error * removed cheerio package as it had high vulnerability in latest update * update sanity reports files * version bump to 3.24.2 --------- Co-authored-by: harshitha.d <harshitha.d@contentstack.com> Co-authored-by: harshithad0703 <104908717+harshithad0703@users.noreply.github.com> --------- Co-authored-by: cs-raj <122264749+cs-raj@users.noreply.github.com> Co-authored-by: Vikram Kalta <vikramkalta@Vikrams-MacBook-Pro.local> Co-authored-by: Vikram Kalta <65945391+vkalta@users.noreply.github.com> Co-authored-by: harshitha.d <harshitha.d@contentstack.com> Co-authored-by: harshithad0703 <104908717+harshithad0703@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor getCacheCallback to directly use parent promise's resolve an…