fix(NativeModuleBase): use reflection for UWP (microsoft#1179)

rozele · web-flow · commit 511d7e8950e6 · 2017-07-04T13:26:56.000Z
This change was previously overlooked. On UWP, expressions are interpreted rather than compiled, so it's actually faster to just use direct reflection.
diff --git a/ReactWindows/ReactNative.Shared/Bridge/NativeModuleBase.cs b/ReactWindows/ReactNative.Shared/Bridge/NativeModuleBase.cs
@@ -44,7 +44,11 @@ private static readonly IReadOnlyDictionary<string, object> s_emptyConstants
         /// Instantiates a <see cref="NativeModuleBase"/>.
         /// </summary>
         protected NativeModuleBase()
+#if WINDOWS_UWP
+            : this(ReflectionReactDelegateFactory.Instance)
+#else
             : this(CompiledReactDelegateFactory.Instance)
+#endif
         {
         }
 
diff --git a/ReactWindows/ReactNative.Shared/Modules/Core/Timing.cs b/ReactWindows/ReactNative.Shared/Modules/Core/Timing.cs
@@ -29,11 +29,7 @@ public class Timing : ReactContextNativeModuleBase, ILifecycleEventListener
         /// </summary>
         /// <param name="reactContext">The React context.</param>
         public Timing(ReactContext reactContext)
-#if WINDOWS_UWP
             : base(reactContext)
-#else
-            : base(reactContext, CompiledReactDelegateFactory.Instance)
-#endif
         {
             _timers = new HeapBasedPriorityQueue<TimerData>(
                 Comparer<TimerData>.Create((x, y) => 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,11 @@ private static readonly IReadOnlyDictionary<string, object> s_emptyConstants`
`44`	`44`	`/// Instantiates a <see cref="NativeModuleBase"/>.`
`45`	`45`	`/// </summary>`
`46`	`46`	`protected NativeModuleBase()`
	`47`	`+#if WINDOWS_UWP`
	`48`	`+ : this(ReflectionReactDelegateFactory.Instance)`
	`49`	`+#else`
`47`	`50`	`: this(CompiledReactDelegateFactory.Instance)`
	`51`	`+#endif`
`48`	`52`	`{`
`49`	`53`	`}`
`50`	`54`