fix(ReactTextView): Add support for 'padding' property

ebragge · ebragge · commit 6070b5bdbe8c · 2016-05-18T16:10:20.000+03:00
Fixes microsoft#410
diff --git a/ReactWindows/ReactNative/Views/Text/ReactTextShadowNode.cs b/ReactWindows/ReactNative/Views/Text/ReactTextShadowNode.cs
@@ -121,12 +121,29 @@ public override void OnCollectExtraUpdates(UIViewOperationQueue uiViewOperationQ
 
             if (_inline != null)
             {
+                var _paddings = new Thickness()
+                {
+                    Left =  float.IsNaN(GetPadding(CSSSpacingType.Left)) ?
+                                float.IsNaN(GetPadding(CSSSpacingType.Horizontal)) ?
+                                    float.IsNaN(GetPadding(CSSSpacingType.All)) ? 0 : 
+                                    GetPadding(CSSSpacingType.All) :
+                                GetPadding(CSSSpacingType.Horizontal) :
+                            GetPadding(CSSSpacingType.Left),
+                    Top =   float.IsNaN(GetPadding(CSSSpacingType.Top)) ?
+                                float.IsNaN(GetPadding(CSSSpacingType.Vertical)) ?
+                                    float.IsNaN(GetPadding(CSSSpacingType.All)) ? 0 :
+                                    GetPadding(CSSSpacingType.All) :
+                                GetPadding(CSSSpacingType.Vertical) :
+                            GetPadding(CSSSpacingType.Top),
+                };
+
                 var args = Tuple.Create(
                     _inline,
                     _textAlignment,
                     _lineHeight,
                     _numberOfLines,
-                    _letterSpacing);
+                    _letterSpacing,
+                    _paddings);
 
                 uiViewOperationQueue.EnqueueUpdateExtraData(ReactTag, args);
             }
@@ -394,7 +411,7 @@ private static MeasureOutput MeasureText(CSSNode node, float width, float height
                 textBlock.CharacterSpacing = textNode._letterSpacing;
                 textBlock.LineHeight = textNode._lineHeight;
                 textBlock.MaxLines = textNode._numberOfLines;
-                textBlock.TextAlignment = (TextAlignment)textNode._textAlignment;
+                textBlock.TextAlignment = textNode._textAlignment;
 
                 textBlock.Inlines.Add(ReactTextShadowNodeInlineVisitor.Apply(node));
 
diff --git a/ReactWindows/ReactNative/Views/Text/ReactTextViewManager.cs b/ReactWindows/ReactNative/Views/Text/ReactTextViewManager.cs
@@ -40,7 +40,7 @@ public override ReactTextShadowNode CreateShadowNodeInstance()
         /// <param name="extraData">The aggregated virtual node changes.</param>
         public override void UpdateExtraData(TextBlock root, object extraData)
         {
-            var textUpdate = (Tuple<Inline, TextAlignment, double, int, int>)extraData;
+            var textUpdate = (Tuple<Inline, TextAlignment, double, int, int, Thickness>)extraData;
             var inline = textUpdate.Item1;
 
             root.Inlines.Clear();
@@ -49,7 +49,8 @@ public override void UpdateExtraData(TextBlock root, object extraData)
             root.TextAlignment = textUpdate.Item2;
             root.LineHeight = textUpdate.Item3;
             root.MaxLines = textUpdate.Item4;
-            root.CharacterSpacing = textUpdate.Item5;     
+            root.CharacterSpacing = textUpdate.Item5; 
+            root.Padding = textUpdate.Item6;
         }
 
         /// <summary>
