Proper escaption of .sln file in command line args (microsoft#582)

MaxiBoether · mpodwysocki · commit 798f64b49e8e · 2016-08-10T17:21:22.000-04:00
The call of msbuild.exe wasn't done with a properly escaped version of slnFile, so paths including whitespaces resulted in an error. This is fixed by adding quotation marks in front of and at the end of the slnFile.
diff --git a/local-cli/runWindows/utils/msbuildtools.js b/local-cli/runWindows/utils/msbuildtools.js
@@ -47,7 +47,7 @@ class MSBuildTools {
       return;
     }
 
-    const cmd = `"${path.join(this.path, 'msbuild.exe')}" ` + [slnFile].concat(args).join(' ');
+    const cmd = `"${path.join(this.path, 'msbuild.exe')}" ` + ['"' + slnFile + '"'].concat(args).join(' ');
     const results = child_process.execSync(cmd).toString().split(EOL);
     results.forEach(result => console.log(chalk.white(result)));
   }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class MSBuildTools {`
`47`	`47`	`return;`
`48`	`48`	`}`
`49`	`49`
`50`		- const cmd = `"${path.join(this.path, 'msbuild.exe')}" ` + [slnFile].concat(args).join(' ');
	`50`	+ const cmd = `"${path.join(this.path, 'msbuild.exe')}" ` + ['"' + slnFile + '"'].concat(args).join(' ');
`51`	`51`	`const results = child_process.execSync(cmd).toString().split(EOL);`
`52`	`52`	`results.forEach(result => console.log(chalk.white(result)));`
`53`	`53`	`}`