Move "RootView.Background = ..." into CreateRootView(), so that subclasses can return a RootView with their own Background (microsoft#1117)

ndbroadbent · rozele · commit 8da9f03fa1b0 · 2017-05-23T10:52:55.000-04:00
diff --git a/ReactWindows/ReactNative/ReactPage.cs b/ReactWindows/ReactNative/ReactPage.cs
@@ -110,8 +110,6 @@ public void OnCreate(string arguments)
         /// <param name="initialProps">The initialProps.</param>
         public void OnCreate(string arguments, JObject initialProps)
         {
-            RootView.Background = (Brush)Application.Current.Resources["ApplicationPageBackgroundThemeBrush"];
-
             ApplyArguments(arguments);
             RootView.StartReactApplication(_reactInstanceManager, MainComponentName, initialProps);
 
@@ -163,7 +161,9 @@ public Task DisposeAsync()
         /// </remarks>
         protected virtual ReactRootView CreateRootView()
         {
-            return new ReactRootView();
+            ReactRootView rootView = new ReactRootView();
+            rootView.Background = (Brush)Application.Current.Resources["ApplicationPageBackgroundThemeBrush"];
+            return rootView;
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -110,8 +110,6 @@ public void OnCreate(string arguments)`
`110`	`110`	`/// <param name="initialProps">The initialProps.</param>`
`111`	`111`	`public void OnCreate(string arguments, JObject initialProps)`
`112`	`112`	`{`
`113`		`- RootView.Background = (Brush)Application.Current.Resources["ApplicationPageBackgroundThemeBrush"];`
`114`		`-`
`115`	`113`	`ApplyArguments(arguments);`
`116`	`114`	`RootView.StartReactApplication(_reactInstanceManager, MainComponentName, initialProps);`
`117`	`115`
`@@ -163,7 +161,9 @@ public Task DisposeAsync()`
`163`	`161`	`/// </remarks>`
`164`	`162`	`protected virtual ReactRootView CreateRootView()`
`165`	`163`	`{`
`166`		`- return new ReactRootView();`
	`164`	`+ ReactRootView rootView = new ReactRootView();`
	`165`	`+ rootView.Background = (Brush)Application.Current.Resources["ApplicationPageBackgroundThemeBrush"];`
	`166`	`+ return rootView;`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`/// <summary>`