Skip to content

Commit bcc0dc8

Browse files
committed
fix(ReactPropTypes): Remove deep linking to ReactPropTypes
In future versions of react, this kind of deep linking will not be supported. We're eliminating it to ensure there are no issues.
1 parent dce4bf4 commit bcc0dc8

File tree

8 files changed

+19
-12
lines changed

8 files changed

+19
-12
lines changed

Libraries/Components/ActivityIndicator/ActivityIndicator.windows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@
1414
const ColorPropType = require('ColorPropType');
1515
const NativeMethodsMixin = require('NativeMethodsMixin');
1616
const Platform = require('Platform');
17-
const PropTypes = require('react/lib/ReactPropTypes');
1817
const React = require('React');
1918
const StyleSheet = require('StyleSheet');
2019
const View = require('View');
2120

2221
const requireNativeComponent = require('requireNativeComponent');
2322

23+
const PropTypes = React.PropTypes;
24+
2425
const GRAY = '#999999';
2526

2627
/**

Libraries/Components/FlipViewWindows/FlipViewWindows.windows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@
99
var React = require('React');
1010
var ReactNative = require('ReactNative');
1111
var ReactElement = require('react/lib/ReactElement');
12-
var ReactPropTypes = require('react/lib/ReactPropTypes');
1312
var UIManager = require('UIManager');
1413
var View = require('View');
1514

1615
var requireNativeComponent = require('requireNativeComponent');
1716

17+
var ReactPropTypes = React.PropTypes;
18+
1819
var FLIPVIEW_REF = 'flipView';
1920

2021
type Event = Object;

Libraries/Components/PasswordBoxWindows/PasswordBoxWindows.windows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
var DocumentSelectionState = require('DocumentSelectionState');
1515
var EventEmitter = require('EventEmitter');
1616
var NativeMethodsMixin = require('NativeMethodsMixin');
17-
var PropTypes = require('react/lib/ReactPropTypes');
1817
var React = require('React');
1918
var ReactNative = require('ReactNative');
2019
var StyleSheet = require('StyleSheet');
@@ -26,6 +25,8 @@ var View = require('View');
2625

2726
var requireNativeComponent = require('requireNativeComponent');
2827

28+
var PropTypes = React.PropTypes;
29+
2930
var NativePasswordBox = requireNativeComponent('PasswordBoxWindows', null);
3031

3132
type Event = Object;

Libraries/Components/Picker/PickerWindows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
var ColorPropType = require('ColorPropType');
1616
var React = require('React');
1717
var ReactChildren = require('react/lib/ReactChildren');
18-
var ReactPropTypes = require('react/lib/ReactPropTypes');
1918
var StyleSheet = require('StyleSheet');
2019
var StyleSheetPropType = require('StyleSheetPropType');
2120
var View = require('View');
@@ -24,6 +23,8 @@ var ViewStylePropTypes = require('ViewStylePropTypes');
2423
var processColor = require('processColor');
2524
var requireNativeComponent = require('requireNativeComponent');
2625

26+
var ReactPropTypes = React.PropTypes;
27+
2728
var REF_PICKER = 'picker';
2829

2930
var pickerStyleType = StyleSheetPropType({

Libraries/Components/ProgressBarWindows/ProgressBarWindows.windows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@
77
'use strict';
88

99
var React = require('React');
10-
var ReactPropTypes = require('react/lib/ReactPropTypes');
1110
var ReactNativeViewAttributes = require('ReactNativeViewAttributes');
1211
var View = require('View');
1312
var ColorPropType = require('ColorPropType');
1413

1514
var requireNativeComponent = require('requireNativeComponent');
1615

16+
var ReactPropTypes = React.PropTypes;
17+
1718
/**
1819
* React component that wraps the Windows-only `ProgressBar`. This component is used to indicate
1920
* that the app is loading or there is some activity in the app.

Libraries/Components/ProgressRingWindows/ProgressRingWindows.windows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,13 @@
77
'use strict';
88

99
var React = require('React');
10-
var ReactPropTypes = require('react/lib/ReactPropTypes');
1110
var ReactNativeViewAttributes = require('ReactNativeViewAttributes');
1211
var View = require('View');
1312
var requireNativeComponent = require('requireNativeComponent');
1413
var ColorPropType = require('ColorPropType');
1514

15+
var ReactPropTypes = React.PropTypes;
16+
1617
var ProgressRingWindows = React.createClass({
1718
propTypes: {
1819
...View.propTypes,

Libraries/Components/SplitViewWindows/SplitViewWindows.windows.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
var NativeMethodsMixin = require('NativeMethodsMixin');
1414
var React = require('React');
1515
var ReactNative = require('ReactNative');
16-
var ReactPropTypes = require('react/lib/ReactPropTypes');
1716
var StyleSheet = require('StyleSheet');
1817
var UIManager = require('UIManager');
1918
var View = require('View');
@@ -23,6 +22,8 @@ var SplitViewConsts = UIManager.WindowsSplitView.Constants;
2322
var dismissKeyboard = require('dismissKeyboard');
2423
var requireNativeComponent = require('requireNativeComponent');
2524

25+
var ReactPropTypes = React.PropTypes;
26+
2627
var RK_PANE_REF = 'paneView';
2728
var CONTENT_REF = 'contentView';
2829

Libraries/Components/TextInput/TextInput.windows.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@ var DocumentSelectionState = require('DocumentSelectionState');
1515
var EventEmitter = require('EventEmitter');
1616
var NativeMethodsMixin = require('NativeMethodsMixin');
1717
var Platform = require('Platform');
18-
var PropTypes = require('react/lib/ReactPropTypes');
1918
var React = require('React');
2019
var ReactNative = require('ReactNative');
21-
var ReactChildren = require('react/lib/ReactChildren');
2220
var StyleSheet = require('StyleSheet');
2321
var Text = require('Text');
2422
var TextInputState = require('TextInputState');
@@ -32,6 +30,8 @@ var emptyFunction = require('fbjs/lib/emptyFunction');
3230
var invariant = require('fbjs/lib/invariant');
3331
var requireNativeComponent = require('requireNativeComponent');
3432

33+
var PropTypes = React.PropTypes;
34+
3535
var onlyMultiline = {
3636
onTextInput: true, // not supported in Open Source yet
3737
children: true,
@@ -483,7 +483,7 @@ var TextInput = React.createClass({
483483

484484
var children = props.children;
485485
var childCount = 0;
486-
ReactChildren.forEach(children, () => ++childCount);
486+
React.Children.forEach(children, () => ++childCount);
487487
invariant(
488488
!(props.value && childCount),
489489
'Cannot specify both value and children.'
@@ -538,7 +538,7 @@ var TextInput = React.createClass({
538538
UIManager.AndroidTextInput.Constants.AutoCapitalizationType[this.props.autoCapitalize];
539539
var children = this.props.children;
540540
var childCount = 0;
541-
ReactChildren.forEach(children, () => ++childCount);
541+
React.Children.forEach(children, () => ++childCount);
542542
invariant(
543543
!(this.props.value && childCount),
544544
'Cannot specify both value and children.'
@@ -626,7 +626,7 @@ var TextInput = React.createClass({
626626

627627
var children = this.props.children;
628628
var childCount = 0;
629-
ReactChildren.forEach(children, () => ++childCount);
629+
React.Children.forEach(children, () => ++childCount);
630630
invariant(
631631
!childCount,
632632
'TextInput children are not supported on Windows.'

0 commit comments

Comments
 (0)