fix(tag): improve tag resolution handling

Byron · Byron · commit 15b6bbac7bce · 2016-12-22T12:36:49.000+01:00
The handling is similar, but the error message makes clear what is happening, and what can be done to handle such a case. Related to gitpython-developers#561
diff --git a/git/refs/tag.py b/git/refs/tag.py
@@ -22,14 +22,17 @@ class TagReference(Reference):
 
     @property
     def commit(self):
-        """:return: Commit object the tag ref points to"""
+        """:return: Commit object the tag ref points to
+        
+        :raise ValueError: if the tag points to a tree or blob"""
         obj = self.object
         while obj.type != 'commit':
             if obj.type == "tag":
                 # it is a tag object which carries the commit as an object - we can point to anything
                 obj = obj.object
             else:
-                raise ValueError("Tag %s points to a Blob or Tree - have never seen that before" % self)
+                raise ValueError(("Cannot resolve commit as tag %s points to a %s object - "
+                                 + "use the `.object` property instead to access it") % (self, obj.type))
         return obj
 
     @property
