refactor: linkedSignal source cleanup

xidedix · xidedix · commit 8cfa988c3efc · 2025-02-17T16:06:50.000+01:00
diff --git a/projects/coreui-angular/src/lib/alert/alert.component.ts b/projects/coreui-angular/src/lib/alert/alert.component.ts
@@ -73,7 +73,7 @@ export class AlertComponent {
   readonly dismissibleInput = input(false, { transform: booleanAttribute, alias: 'dismissible' });
 
   readonly #dismissible = linkedSignal({
-    source: () => this.dismissibleInput(),
+    source: this.dismissibleInput,
     computation: (value) => {
       return value;
     }
@@ -100,7 +100,7 @@ export class AlertComponent {
   readonly visibleInput = input(true, { transform: booleanAttribute, alias: 'visible' });
 
   readonly #visible = linkedSignal({
-    source: () => this.visibleInput(),
+    source: this.visibleInput,
     computation: (value) => {
       return value;
     }
diff --git a/projects/coreui-angular/src/lib/carousel/carousel-control/carousel-control.component.ts b/projects/coreui-angular/src/lib/carousel/carousel-control/carousel-control.component.ts
@@ -23,7 +23,7 @@ export class CarouselControlComponent {
   readonly captionInput = input<string | undefined>(undefined, { alias: 'caption' });
 
   readonly caption = linkedSignal({
-    source: () => this.captionInput(),
+    source: this.captionInput,
     computation: (value) => {
       return !!value ? value : this.direction() === 'prev' ? 'Previous' : 'Next';
     }
diff --git a/projects/coreui-angular/src/lib/carousel/carousel-item/carousel-item.component.ts b/projects/coreui-angular/src/lib/carousel/carousel-item/carousel-item.component.ts
@@ -26,7 +26,7 @@ export class CarouselItemComponent {
   readonly activeInput = input(false, { transform: booleanAttribute, alias: 'active' });
 
   readonly active = linkedSignal({
-    source: () => this.activeInput(),
+    source: this.activeInput,
     computation: (value) => {
       return value;
     }
diff --git a/projects/coreui-angular/src/lib/carousel/carousel/carousel.component.ts b/projects/coreui-angular/src/lib/carousel/carousel/carousel.component.ts
@@ -61,7 +61,7 @@ export class CarouselComponent implements OnInit, OnDestroy, AfterContentInit {
   readonly activeIndexInput = input<number>(0, { alias: 'activeIndex' });
 
   readonly activeIndex = linkedSignal({
-    source: () => this.activeIndexInput(),
+    source: this.activeIndexInput,
     computation: (value: number) => value
   });
 
@@ -72,7 +72,7 @@ export class CarouselComponent implements OnInit, OnDestroy, AfterContentInit {
   readonly animateInput = input<boolean>(true, { alias: 'animate' });
 
   readonly animate = linkedSignal({
-    source: () => this.animateInput(),
+    source: this.animateInput,
     computation: (value: boolean) => value
   });
 
@@ -83,7 +83,7 @@ export class CarouselComponent implements OnInit, OnDestroy, AfterContentInit {
   readonly directionInput = input<'next' | 'prev'>('next', { alias: 'direction' });
 
   readonly direction = linkedSignal({
-    source: () => this.directionInput(),
+    source: this.directionInput,
     computation: (value: 'next' | 'prev') => value
   });
 
@@ -95,7 +95,7 @@ export class CarouselComponent implements OnInit, OnDestroy, AfterContentInit {
   readonly intervalInput = input<number>(0, { alias: 'interval' });
 
   readonly interval = linkedSignal({
-    source: () => this.intervalInput(),
+    source: this.intervalInput,
     computation: (value: number) => value
   });
 
diff --git a/projects/coreui-angular/src/lib/collapse/collapse.directive.ts b/projects/coreui-angular/src/lib/collapse/collapse.directive.ts
@@ -48,7 +48,7 @@ export class CollapseDirective implements OnDestroy {
   readonly animateInput = input(true, { transform: booleanAttribute, alias: 'animate' });
 
   readonly animate = linkedSignal({
-    source: () => this.animateInput(),
+    source: this.animateInput,
     computation: (value: boolean) => value
   });
 
@@ -68,7 +68,7 @@ export class CollapseDirective implements OnDestroy {
 
   readonly visibleChange = output<boolean>();
 
-  readonly visible = linkedSignal({ source: () => this.visibleInput(), computation: (value: boolean) => value });
+  readonly visible = linkedSignal({ source: this.visibleInput, computation: (value: boolean) => value });
 
   readonly #initialized = signal(false);
 
diff --git a/projects/coreui-angular/src/lib/dropdown/dropdown-menu/dropdown-menu.directive.ts b/projects/coreui-angular/src/lib/dropdown/dropdown-menu/dropdown-menu.directive.ts
@@ -1,5 +1,6 @@
 import {
   AfterContentInit,
+  booleanAttribute,
   computed,
   ContentChildren,
   DestroyRef,
@@ -48,10 +49,10 @@ export class DropdownMenuDirective implements OnInit, AfterContentInit {
    * Toggle the visibility of dropdown menu component.
    * @return boolean
    */
-  readonly visibleInput = input<boolean>(false, { alias: 'visible' });
+  readonly visibleInput = input(false, { transform: booleanAttribute, alias: 'visible' });
 
   readonly visible = linkedSignal({
-    source: () => this.visibleInput(),
+    source: this.visibleInput,
     computation: (value) => value
   });
 
diff --git a/projects/coreui-angular/src/lib/dropdown/dropdown/dropdown.component.ts b/projects/coreui-angular/src/lib/dropdown/dropdown/dropdown.component.ts
@@ -232,10 +232,10 @@ export class DropdownComponent implements AfterContentInit, OnDestroy, OnInit {
    * @return boolean
    * @default false
    */
-  readonly visibleInput = input<boolean, unknown>(false, { transform: booleanAttribute, alias: 'visible' });
+  readonly visibleInput = input(false, { transform: booleanAttribute, alias: 'visible' });
 
   readonly visible = linkedSignal({
-    source: () => this.visibleInput(),
+    source: this.visibleInput,
     computation: (value) => value
   });
 
diff --git a/projects/coreui-angular/src/lib/offcanvas/offcanvas/offcanvas.component.ts b/projects/coreui-angular/src/lib/offcanvas/offcanvas/offcanvas.component.ts
@@ -139,7 +139,7 @@ export class OffcanvasComponent implements OnInit, OnDestroy {
   readonly visibleInput = input(false, { transform: booleanAttribute, alias: 'visible' });
 
   readonly visible = linkedSignal({
-    source: () => this.visibleInput(),
+    source: this.visibleInput,
     computation: (value) => value
   });
 

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export class CarouselControlComponent {`
`23`	`23`	`readonly captionInput = input<string \| undefined>(undefined, { alias: 'caption' });`
`24`	`24`
`25`	`25`	`readonly caption = linkedSignal({`
`26`		`- source: () => this.captionInput(),`
	`26`	`+ source: this.captionInput,`
`27`	`27`	`computation: (value) => {`
`28`	`28`	`return !!value ? value : this.direction() === 'prev' ? 'Previous' : 'Next';`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export class CarouselItemComponent {`
`26`	`26`	`readonly activeInput = input(false, { transform: booleanAttribute, alias: 'active' });`
`27`	`27`
`28`	`28`	`readonly active = linkedSignal({`
`29`		`- source: () => this.activeInput(),`
	`29`	`+ source: this.activeInput,`
`30`	`30`	`computation: (value) => {`
`31`	`31`	`return value;`
`32`	`32`	`}`