refactor(CPopover, CTooltip): improve syntax

mrholek · mrholek · commit 62de667de4cb · 2023-07-01T01:11:37.000+02:00
diff --git a/packages/coreui-vue/src/components/popover/CPopover.ts b/packages/coreui-vue/src/components/popover/CPopover.ts
@@ -2,21 +2,7 @@ import { defineComponent, h, PropType, ref, RendererElement, Teleport, Transitio
 import { createPopper, Placement } from '@popperjs/core'
 
 import { executeAfterTransition } from '../../utils/transition'
-import { isRTL } from '../../utils'
-
-const getPlacement = (placement: string, element: HTMLDivElement | null): Placement => {
-  switch (placement) {
-    case 'right': {
-      return isRTL(element) ? 'left' : 'right'
-    }
-    case 'left': {
-      return isRTL(element) ? 'right' : 'left'
-    }
-    default: {
-      return placement as Placement
-    }
-  }
-}
+import { getRTLPlacement } from '../../utils'
 
 const CPopover = defineComponent({
   name: 'CPopover',
@@ -109,7 +95,7 @@ const CPopover = defineComponent({
     const initPopper = () => {
       if (togglerRef.value) {
         popper.value = createPopper(togglerRef.value, popoverRef.value, {
-          placement: getPlacement(props.placement, togglerRef.value),
+          placement: getRTLPlacement(props.placement, togglerRef.value),
           modifiers: [
             {
               name: 'offset',
diff --git a/packages/coreui-vue/src/components/tooltip/CTooltip.ts b/packages/coreui-vue/src/components/tooltip/CTooltip.ts
@@ -2,21 +2,7 @@ import { defineComponent, h, PropType, ref, RendererElement, Teleport, Transitio
 import { createPopper, Placement } from '@popperjs/core'
 
 import { executeAfterTransition } from '../../utils/transition'
-import { isRTL } from '../../utils'
-
-const getPlacement = (placement: string, element: HTMLDivElement | null): Placement => {
-  switch (placement) {
-    case 'right': {
-      return isRTL(element) ? 'left' : 'right'
-    }
-    case 'left': {
-      return isRTL(element) ? 'right' : 'left'
-    }
-    default: {
-      return placement as Placement
-    }
-  }
-}
+import { getRTLPlacement } from '../../utils'
 
 const CTooltip = defineComponent({
   name: 'CTooltip',
@@ -105,7 +91,7 @@ const CTooltip = defineComponent({
     const initPopper = () => {
       if (togglerRef.value) {
         popper.value = createPopper(togglerRef.value, tooltipRef.value, {
-          placement: getPlacement(props.placement, togglerRef.value),
+          placement: getRTLPlacement(props.placement, togglerRef.value),
           modifiers: [
             {
               name: 'offset',
diff --git a/packages/coreui-vue/src/utils/getRTLPlacement.ts b/packages/coreui-vue/src/utils/getRTLPlacement.ts
@@ -0,0 +1,18 @@
+import { Placement } from '@popperjs/core'
+import { isRTL } from '../utils'
+
+const getRTLPlacement = (placement: string, element: HTMLDivElement | null): Placement => {
+  switch (placement) {
+    case 'right': {
+      return isRTL(element) ? 'left' : 'right'
+    }
+    case 'left': {
+      return isRTL(element) ? 'right' : 'left'
+    }
+    default: {
+      return placement as Placement
+    }
+  }
+}
+
+export default getRTLPlacement
diff --git a/packages/coreui-vue/src/utils/index.ts b/packages/coreui-vue/src/utils/index.ts
@@ -1,5 +1,6 @@
+import getRTLPlacement from './getRTLPlacement'
 import getUID from './getUID'
 import isInViewport from './isInViewport'
 import isRTL from './isRTL'
 
-export { getUID, isInViewport, isRTL }
+export { getRTLPlacement, getUID, isInViewport, isRTL }
