Ugly hack for messagebus to return results [hack_messagebus_results]

hjwp · hjwp · commit 516d322b838f · 2024-03-01T15:05:12.000Z
diff --git a/src/allocation/service_layer/messagebus.py b/src/allocation/service_layer/messagebus.py
@@ -11,12 +11,14 @@ def handle(
     event: events.Event,
     uow: unit_of_work.AbstractUnitOfWork,
 ):
+    results = []
     queue = [event]
     while queue:
         event = queue.pop(0)
         for handler in HANDLERS[type(event)]:
-            handler(event, uow=uow)
+            results.append(handler(event, uow=uow))
             queue.extend(uow.collect_new_events())
+    return results
 
 
 HANDLERS = {
diff --git a/tests/unit/test_handlers.py b/tests/unit/test_handlers.py
@@ -53,10 +53,10 @@ def test_returns_allocation(self):
         messagebus.handle(
             events.BatchCreated("batch1", "COMPLICATED-LAMP", 100, None), uow
         )
-        result = messagebus.handle(
+        results = messagebus.handle(
             events.AllocationRequired("o1", "COMPLICATED-LAMP", 10), uow
         )
-        assert result == "batch1"
+        assert results.pop(0) == "batch1"
 
     def test_errors_for_invalid_sku(self):
         uow = FakeUnitOfWork()

Original file line number	Diff line number	Diff line change
`@@ -53,10 +53,10 @@ def test_returns_allocation(self):`
`53`	`53`	`messagebus.handle(`
`54`	`54`	`events.BatchCreated("batch1", "COMPLICATED-LAMP", 100, None), uow`
`55`	`55`	`)`
`56`		`- result = messagebus.handle(`
	`56`	`+ results = messagebus.handle(`
`57`	`57`	`events.AllocationRequired("o1", "COMPLICATED-LAMP", 10), uow`
`58`	`58`	`)`
`59`		`- assert result == "batch1"`
	`59`	`+ assert results.pop(0) == "batch1"`
`60`	`60`
`61`	`61`	`def test_errors_for_invalid_sku(self):`
`62`	`62`	`uow = FakeUnitOfWork()`