uow now does messagebus magically. breaks tests [uow_has_messagebus]

hjwp · hjwp · commit 5ffb463a3561 · 2024-03-01T15:01:36.000Z
diff --git a/src/allocation/adapters/repository.py b/src/allocation/adapters/repository.py
@@ -1,4 +1,5 @@
 import abc
+from typing import Set
 from allocation.domain import model
 
 
@@ -15,9 +16,14 @@ def get(self, sku) -> model.Product:
 class SqlAlchemyRepository(AbstractRepository):
     def __init__(self, session):
         self.session = session
+        self.seen = set()  # type: Set[model.Product]
 
     def add(self, product):
+        self.seen.add(product)
         self.session.add(product)
 
     def get(self, sku):
-        return self.session.query(model.Product).filter_by(sku=sku).first()
+        product = self.session.query(model.Product).filter_by(sku=sku).first()
+        if product:
+            self.seen.add(product)
+        return product
diff --git a/src/allocation/service_layer/services.py b/src/allocation/service_layer/services.py
@@ -4,7 +4,6 @@
 
 from allocation.domain import model
 from allocation.domain.model import OrderLine
-from . import messagebus
 
 if TYPE_CHECKING:
     from . import unit_of_work
@@ -36,9 +35,6 @@ def allocate(
         product = uow.products.get(sku=line.sku)
         if product is None:
             raise InvalidSku(f"Invalid sku {line.sku}")
-        try:
-            batchref = product.allocate(line)
-            uow.commit()
-            return batchref
-        finally:
-            messagebus.handle(product.events)
+        batchref = product.allocate(line)
+        uow.commit()
+        return batchref
diff --git a/src/allocation/service_layer/unit_of_work.py b/src/allocation/service_layer/unit_of_work.py
@@ -5,8 +5,10 @@
 from sqlalchemy.orm import sessionmaker
 from sqlalchemy.orm.session import Session
 
+
 from allocation import config
 from allocation.adapters import repository
+from . import messagebus
 
 
 class AbstractUnitOfWork(abc.ABC):
@@ -18,8 +20,18 @@ def __enter__(self) -> AbstractUnitOfWork:
     def __exit__(self, *args):
         self.rollback()
 
-    @abc.abstractmethod
     def commit(self):
+        self._commit()
+        self.publish_events()
+
+    def publish_events(self):
+        for product in self.products.seen:
+            while product.events:
+                event = product.events.pop(0)
+                messagebus.handle(event)
+
+    @abc.abstractmethod
+    def _commit(self):
         raise NotImplementedError
 
     @abc.abstractmethod
@@ -48,7 +60,7 @@ def __exit__(self, *args):
         super().__exit__(*args)
         self.session.close()
 
-    def commit(self):
+    def _commit(self):
         self.session.commit()
 
     def rollback(self):
diff --git a/tests/unit/test_services.py b/tests/unit/test_services.py
@@ -20,7 +20,7 @@ def __init__(self):
         self.products = FakeRepository([])
         self.committed = False
 
-    def commit(self):
+    def _commit(self):
         self.committed = True
 
     def rollback(self):
