Skip to content

Minimum queue removal logic is wrong #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buydrpepper opened this issue May 16, 2025 · 0 comments
Open

Minimum queue removal logic is wrong #1462

buydrpepper opened this issue May 16, 2025 · 0 comments

Comments

@buydrpepper
Copy link

Under (method 2):
if (!q.empty() && q.front().second == cnt_removed)
q.pop_front();
cnt_removed++;

Correct me if I'm wrong, but this should either not include the empty check at all, or increment cnt_removed only if the queue is nonempty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant