Skip to content

update old links #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2018
Merged

update old links #276

merged 3 commits into from
Oct 2, 2018

Conversation

goswami-rahul
Copy link
Contributor

@@ -18,7 +18,7 @@ The most important property of the condensation graph is that it is **acyclic**.
The algorithm described in the next section extracts all strongly connected components in a given graph. It is quite easy to build a condensation graph then.

## Description of the algorithm
Described algorithm was independently suggested by Kosaraju and Sharir at 1979. This is an easy-to-implement algorithm based on two series of [depth first search](http://e-maxx-eng.appspot.com/graph/depth-first-search.html), and working for $O(n + m)$ time.
Described algorithm was independently suggested by Kosaraju and Sharir at 1979. This is an easy-to-implement algorithm based on two series of [depth first search](https://cp-algorithms.com/graph/depth-first-search.html), and working for $O(n + m)$ time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this link and the next one, it would be better to use relative links instead of the absolute ones: depth first search

@tcNickolas
Copy link
Member

There is one more occurrence of old URL in the pages, at src/combinatorics/generating_combinations.md. Do you want to fix it to a relative link too? This way all related changes would be in one commit.

@jakobkogler
Copy link
Member

Actually I already fixed it, while tcNickolas did the review. Maybe I shouldn't do all the work myself, and let the people fix their own mistakes?

@jakobkogler jakobkogler merged commit 783512e into cp-algorithms:master Oct 2, 2018
@goswami-rahul
Copy link
Contributor Author

Thanks for the fixes @jakobkogler :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants