Skip to content

P3371 R4 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wg21bot opened this issue Aug 15, 2024 · 5 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 C++29 Targeted at C++29 IS Ship vehicle: IS LWG Library lwg-pending LWG Chair needs to disposition
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Aug 15, 2024

P3371R0 Fix C++26 by making the symmetric and Hermitian rank-k and rank-2k updates consistent with the BLAS (Mark Hoemmen)

@wg21bot wg21bot added LEWG Library Evolution LWG Library labels Aug 15, 2024
@wg21bot wg21bot added this to the 2024-telecon milestone Aug 15, 2024
@wg21bot
Copy link
Collaborator Author

wg21bot commented Sep 21, 2024

P3371R1 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS (Mark Hoemmen, Ilya Burylov)

@wg21bot wg21bot changed the title P3371 R0 Fix C++26 by making the symmetric and Hermitian rank-k and rank-2k updates consistent with the BLAS P3371 R1 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS Sep 21, 2024
@cor3ntin cor3ntin removed the LWG Library label Sep 22, 2024
@inbal2l inbal2l added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Oct 7, 2024
@inbal2l inbal2l added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 IS Ship vehicle: IS labels Oct 7, 2024
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 17, 2024

P3371R2 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS (Mark Hoemmen, Ilya Burylov)

@wg21bot wg21bot changed the title P3371 R1 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS P3371 R2 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS Oct 17, 2024
@wg21bot
Copy link
Collaborator Author

wg21bot commented Dec 18, 2024

P3371R3 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS (Mark Hoemmen, Ilya Burylov)

@wg21bot wg21bot modified the milestones: 2024-telecon, 2025-telecon Dec 18, 2024
@wg21bot wg21bot changed the title P3371 R2 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS P3371 R3 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS Dec 18, 2024
@inbal2l
Copy link
Collaborator

inbal2l commented Mar 28, 2025

2025-03-18 Library Evolution Telecon

P3371R3: Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS

2025-03-18 Library Evolution Hagenberg Minutes

Champion: Mark Hoemmen / Ilya Burylov
Chair: Inbal Levi
Minute Taker: Bronek Kozicki

Summary

POLL: We are unhappy with the behaviour currently specified in the paper “Use only the real part of scaling factor alpha for Hermitian matrix rank-1 and rank-k updates”.

SF F N A SA
0 2 2 4 3

Attendance: 17
Author's Position: SA
Outcome: Consensus against

POLL: Reverse the change for “Remove rank-{1,k} overloads without a scaling factor alpha (keep overloads with alpha)”
(voting in favor would mean keeping the overloads)

SF F N A SA
0 3 2 3 1

Attendance: 18
Author's Position: A
Outcome: No consensus for a change

IL: We have some comments on the poll (in respect to moving away from status quo), so just to make sure, let’s take the poll again in the opposite direction (approving modifications proposed in the paper).

POLL: Apply the change as proposed in the paper “Remove rank-{1,k} overloads without a scaling factor alpha”.

SF F N A SA
6 1 1 2 0

Attendance: 18
Author's Position: SF, F
Outcome: Consensus in favor

A: I think the overload might be useful.

POLL: Forward “P3371R3: Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS” to LWG for C++29 with a recommendation to make this a DR for 26.

SF F N A SA
8 4 0 0 0

Attendance: 17
Author's Position: 2xSF
Outcome: Strong consensus in favor

POLL: Forward “P3371R3: Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS” to LWG with a recommendation to apply for C++26 (if possible).

SF F N A SA
8 4 0 0 0

Attendance: 17
Author's Position: 2xSF
Outcome: Strong consensus in favor

Next Steps

Paper was forwarded for C++29 with a recommendation for making this DR for 26. As this is a fix, we also took a second (non-binding) poll that recommends accepting this for C++26 (if LWG’s queue enables).

@inbal2l inbal2l added LWG Library lwg-pending LWG Chair needs to disposition C++29 Targeted at C++29 and removed LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Mar 28, 2025
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 17, 2025

P3371R4 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS (Mark Hoemmen, Ilya Burylov)

@wg21bot wg21bot changed the title P3371 R3 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS P3371 R4 Fix C++26 by making the rank-1, rank-2, rank-k, and rank-2k updates consistent with the BLAS Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 C++29 Targeted at C++29 IS Ship vehicle: IS LWG Library lwg-pending LWG Chair needs to disposition
Projects
Development

No branches or pull requests

3 participants