Skip to content

ISO #8 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camio opened this issue Mar 27, 2021 · 3 comments · Fixed by #101
Closed

ISO #8 #98

camio opened this issue Mar 27, 2021 · 3 comments · Fixed by #101
Labels
iso Feedback from ISO

Comments

@camio
Copy link

camio commented Mar 27, 2021

Please change occurrences of “could” and “might” to “can to express
possibility. Also, “may” is used in a Note, which is not permitted since
Notes cannot contain permissions. In this case, please change to “can” if it
is used to express a possibility. If it is meant to express a permission,
please move the text to regular body text instead.
@camio camio added the iso Feedback from ISO label Mar 27, 2021
@jagrut08
Copy link
Contributor

I'll take this one.

@jagrut08
Copy link
Contributor

Done, with one question. The 'may' in the note is now a 'can'.. but are we giving permission? If so, we would have to change the Note to regular body text.

@jagrut08
Copy link
Contributor

jagrut08 commented Apr 1, 2021

Per discussion with David, the one instance of 'may' within the Note was not giving permission, so don't have to move it to regular body text.

@jagrut08 jagrut08 mentioned this issue Apr 1, 2021
Merged
@camio camio closed this as completed in #101 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iso Feedback from ISO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial changes based on feedback jagrut08/reflection-ts
2 participants
@camio @jagrut08