Skip to content

open to contributions? #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2bndy5 opened this issue Aug 17, 2021 · 3 comments · Fixed by #4
Closed

open to contributions? #3

2bndy5 opened this issue Aug 17, 2021 · 3 comments · Fixed by #4
Labels
help wanted Extra attention is needed

Comments

@2bndy5
Copy link
Collaborator

2bndy5 commented Aug 17, 2021

I'm glad to see someone taking up the torch to update ArtificialAmateur's stale action. I was wondering if you'd be open to contributions. I'd like to add an input option that makes use of clang-format's --style= arg. Also, I think there's a way to consolidate the demo repo into this one.
@shenxianpeng
Copy link
Collaborator

I'm very glad you would like to contribute, and support --style= option will be very helpful, please go ahead.
About consolidate the demo repo into this one, could explain more? Thank you!

@2bndy5
Copy link
Collaborator Author

2bndy5 commented Aug 18, 2021 •
edited
Loading

About consolidate the demo repo into this one, could explain more?

I'm just guessing here, but you could have a "demo" subdirectory in this repo that exists on 2 branches. 1 branch would have a PR open to merge un-formatted code to the other branch. Let the this action run on this repo as you would for any other repo (except pinned to the this repo's master branch instead of a version like shenxianpeng/cpp-linter-action@master), so the PR would demonstrate the bot comments. I'm also guessing the PR could be converted to a draft if it sticks out like a sore thumb in the PR list.

If you decide to expand what the bot says in comments later, it would be easy to delete the comment in the demo PR and do a rebase for the PR'd branch.

@shenxianpeng
Copy link
Collaborator

I think I get your point. I will try to do so, thanks very much.

@shenxianpeng shenxianpeng added the help wanted Extra attention is needed label Aug 18, 2021
@2bndy5 2bndy5 mentioned this issue Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inputs 2bndy5/cpp-linter-action
2 participants
@shenxianpeng @2bndy5