Skip to content

submodules are only ignore if files_changed_only is True #76

Closed
@2bndy5

Description

@2bndy5

I noticed this on a repo I'm developing that has 4 submodules. When the CI runs

cpp-linter --files-changed-only=false

All the submodules are crawled as if they're part of the current repo's original sources.

Moving the algorithm that detects submodules from list_source_files() into parse_ignored_option() should fix this, but I have to be careful to consider if the user explicitly specifies a submodule to be not ignored.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions