From de41419856975240fe9fe23b5400b960366049c1 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Tue, 24 Oct 2023 14:22:13 -0700 Subject: [PATCH 01/28] try update comments using thread-comments dynamic input --- .github/workflows/cpp-lint-package.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index ea23371..d32e4b8 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -49,6 +49,16 @@ jobs: if: steps.cache-build.outputs.cache-hit != 'true' run: mkdir build && cmake -Bbuild src -G "NMake Makefiles" + - name: Update comments? + id: linter-thread-comments + shell: python + run: | + import os + with open(os.environ["GITHUB_OUTPUT"], 'a') as gh_out: + if ${{ matrix.clang-version }} == 12: + gh_out.write('thread-comment=update\n') + else: + gh_out.write('thread-comment=false\n') - name: Run linter as package id: linter env: @@ -62,7 +72,7 @@ jobs: -V=${{ runner.temp }}/llvm -f=false --extra-arg="-std=c++14 -Wall" - --thread-comments=${{ matrix.clang-version == '12' }} + --thread-comments=${{ steps.linter-thread-comments.outputs.thread-comment }} -a=${{ matrix.clang-version == '12' }} - name: Fail fast?! From 26c2bfce55375fcbd3063f973858813cbe96b3f1 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Tue, 24 Oct 2023 14:10:26 -0700 Subject: [PATCH 02/28] enable lgtm comments --- .github/workflows/cpp-lint-package.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index d32e4b8..624a5e1 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -74,6 +74,7 @@ jobs: --extra-arg="-std=c++14 -Wall" --thread-comments=${{ steps.linter-thread-comments.outputs.thread-comment }} -a=${{ matrix.clang-version == '12' }} + --no-lgtm=false - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0 From b0c4f169cc7e3b887589cd83fcf9aafe56daa48a Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Tue, 24 Oct 2023 14:47:32 -0700 Subject: [PATCH 03/28] enable thread-comments for clang v13 --- .github/workflows/cpp-lint-package.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 624a5e1..2ac5206 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -57,6 +57,8 @@ jobs: with open(os.environ["GITHUB_OUTPUT"], 'a') as gh_out: if ${{ matrix.clang-version }} == 12: gh_out.write('thread-comment=update\n') + elif ${{ matrix.clang-version }} == 13: + gh_out.write('thread-comment=true\n') else: gh_out.write('thread-comment=false\n') - name: Run linter as package From 5ac75657c33a422c333dd71929fb194ef803954c Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 26 Oct 2023 16:27:00 -0700 Subject: [PATCH 04/28] trigger workflow on push --- .github/workflows/cpp-lint-package.yml | 29 ++++++++------------------ 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 2ac5206..a71e74e 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -1,12 +1,13 @@ name: cpp-linter as pkg on: - workflow_dispatch: - inputs: - branch: - description: 'which branch to test' - default: 'main' - required: true + # workflow_dispatch: + # inputs: + # branch: + # description: 'which branch to test' + # default: 'main' + # required: true + push: jobs: cpp-linter: @@ -16,7 +17,7 @@ jobs: matrix: clang-version: ['7', '8', '9','10', '11', '12', '13', '14'] repo: ['cpp-linter/cpp-linter'] - branch: ['${{ inputs.branch }}'] + branch: ['resolve-34'] # ['${{ inputs.branch }}'] fail-fast: false steps: @@ -49,18 +50,6 @@ jobs: if: steps.cache-build.outputs.cache-hit != 'true' run: mkdir build && cmake -Bbuild src -G "NMake Makefiles" - - name: Update comments? - id: linter-thread-comments - shell: python - run: | - import os - with open(os.environ["GITHUB_OUTPUT"], 'a') as gh_out: - if ${{ matrix.clang-version }} == 12: - gh_out.write('thread-comment=update\n') - elif ${{ matrix.clang-version }} == 13: - gh_out.write('thread-comment=true\n') - else: - gh_out.write('thread-comment=false\n') - name: Run linter as package id: linter env: @@ -74,7 +63,7 @@ jobs: -V=${{ runner.temp }}/llvm -f=false --extra-arg="-std=c++14 -Wall" - --thread-comments=${{ steps.linter-thread-comments.outputs.thread-comment }} + --thread-comments=update -a=${{ matrix.clang-version == '12' }} --no-lgtm=false From c15acbbffc9949fc9347f8de9ff4353c9ec1a785 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 26 Oct 2023 21:09:51 -0700 Subject: [PATCH 05/28] trigger CI on PR event --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index a71e74e..016e690 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -7,7 +7,7 @@ on: # description: 'which branch to test' # default: 'main' # required: true - push: + pull_request: jobs: cpp-linter: From 9aa0039d88ac74e9e537beabdfd867bda48ec2cf Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 26 Oct 2023 21:57:35 -0700 Subject: [PATCH 06/28] only check files changed --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 016e690..a89d439 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,7 +61,7 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=false + -f=true --extra-arg="-std=c++14 -Wall" --thread-comments=update -a=${{ matrix.clang-version == '12' }} From 83adc1ac35a480a9b763ebe6f8ba5521e8c75cda Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 26 Oct 2023 22:06:55 -0700 Subject: [PATCH 07/28] don't update comments (create anew instead) --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index a89d439..74692e8 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -63,7 +63,7 @@ jobs: -V=${{ runner.temp }}/llvm -f=true --extra-arg="-std=c++14 -Wall" - --thread-comments=update + --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} --no-lgtm=false From c99d7ce9fd744f70d81e35d56caaecc63e00d224 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 26 Oct 2023 22:10:11 -0700 Subject: [PATCH 08/28] check all src files --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 74692e8..dad1838 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,7 +61,7 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=true + -f=false --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} From 6a62e4d07c7975145a7d022f0fcee0ee435ce2c7 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 26 Oct 2023 22:15:52 -0700 Subject: [PATCH 09/28] no-lgtm w/ files changed only --- .github/workflows/cpp-lint-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index dad1838..a7186a1 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,11 +61,11 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=false + -f=true --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} - --no-lgtm=false + --no-lgtm=true - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0 From 00a60ce1451f54e96f175ae6ce9d6e0aded54e01 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 27 Oct 2023 11:00:19 -0700 Subject: [PATCH 10/28] check all files --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index a7186a1..0ec1a24 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,7 +61,7 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=true + -f=false --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} From f58cdd9cbfba6db71d76cff4bff252e0a8cdcbcc Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 27 Oct 2023 22:43:05 -0700 Subject: [PATCH 11/28] update comment w/ no-lgtm=true; only files changed --- .github/workflows/cpp-lint-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 0ec1a24..acf880f 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,9 +61,9 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=false + -f=true --extra-arg="-std=c++14 -Wall" - --thread-comments=${{ matrix.clang-version == '12' }} + --thread-comments=update -a=${{ matrix.clang-version == '12' }} --no-lgtm=true From 9308fdfc563d80a5f909777c772384f58e529aea Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 14:34:17 -0800 Subject: [PATCH 12/28] all files; no-lgtm; anew comment --- .github/workflows/cpp-lint-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index acf880f..0ec1a24 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,9 +61,9 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=true + -f=false --extra-arg="-std=c++14 -Wall" - --thread-comments=update + --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} --no-lgtm=true From 85bb7f1991449ab3dd79fd6a0900e366316c1120 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 14:39:46 -0800 Subject: [PATCH 13/28] only changed files; no-lgtm; anew comment --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 0ec1a24..a7186a1 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,7 +61,7 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=false + -f=true --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' }} -a=${{ matrix.clang-version == '12' }} From 98251eb8c6f6b91778731a03567dc5b131fc03b2 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 14:45:14 -0800 Subject: [PATCH 14/28] all files; no-lgtm; update comment --- .github/workflows/cpp-lint-package.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index a7186a1..b5335c0 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,9 +61,9 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=true + -f=false --extra-arg="-std=c++14 -Wall" - --thread-comments=${{ matrix.clang-version == '12' }} + --thread-comments=${{ matrix.clang-version == '12' && 'update' || 'false' }} -a=${{ matrix.clang-version == '12' }} --no-lgtm=true From 047d1d4ec36503637c50493a74c7fd22b60054a4 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 14:48:27 -0800 Subject: [PATCH 15/28] only files changed; no-lgtm; update comment --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index b5335c0..8ea9153 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,7 +61,7 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=false + -f=true --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' && 'update' || 'false' }} -a=${{ matrix.clang-version == '12' }} From 6243a9ad8e6e9568ea26e0f84d18e311ab1a29ce Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 14:53:51 -0800 Subject: [PATCH 16/28] files changed only; yes-lgtm; update comment --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 8ea9153..eb9e938 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -65,7 +65,7 @@ jobs: --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' && 'update' || 'false' }} -a=${{ matrix.clang-version == '12' }} - --no-lgtm=true + --no-lgtm=false - name: Fail fast?! if: steps.linter.outputs.checks-failed > 0 From 7d454b1cccaecb6b7963bd02fa1855d39f57c626 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 14:56:33 -0800 Subject: [PATCH 17/28] all files; yes-lgtm; update-comment --- .github/workflows/cpp-lint-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index eb9e938..b3463fd 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -61,7 +61,7 @@ jobs: -i=build -p=build -V=${{ runner.temp }}/llvm - -f=true + -f=false --extra-arg="-std=c++14 -Wall" --thread-comments=${{ matrix.clang-version == '12' && 'update' || 'false' }} -a=${{ matrix.clang-version == '12' }} From cdb6418dd48152cfbf5cf0a5cfe3635e42bda0d4 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 9 Nov 2023 15:02:19 -0800 Subject: [PATCH 18/28] only changed files; yes-lgtm; anew comment --- .github/workflows/cpp-lint-package.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index b3463fd..299c567 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -60,10 +60,10 @@ jobs: -v=9 -i=build -p=build - -V=${{ runner.temp }}/llvm - -f=false + -V=${{ runner.temp }}/llvm + -f=true --extra-arg="-std=c++14 -Wall" - --thread-comments=${{ matrix.clang-version == '12' && 'update' || 'false' }} + --thread-comments=${{ matrix.clang-version == '12' && 'true' || 'false' }} -a=${{ matrix.clang-version == '12' }} --no-lgtm=false From 8b0c1a0cc3b47acb90fd7422341e036364926ee8 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 13:09:58 -0800 Subject: [PATCH 19/28] TESTING DEPENDABOT BRANCH trigger workflow on PR sync --- .github/workflows/cpp-lint-action.yml | 5 +++-- .github/workflows/cpp-lint-package.yml | 13 ++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index 0680634..d1d1876 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -3,6 +3,7 @@ name: cpp-linter as action on: workflow_dispatch: workflow_call: + pull_request: jobs: @@ -31,7 +32,7 @@ jobs: run: mkdir build && cmake -Bbuild src - name: Run linter as action - uses: cpp-linter/cpp-linter-action@latest + uses: cpp-linter/cpp-linter-action@dependabot/pip/cpp-linter-1.6.1 id: linter env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} @@ -43,7 +44,7 @@ jobs: database: build verbosity: 9 version: ${{ matrix.clang-version }} - thread-comments: ${{ matrix.clang-version == '12' }} + thread-comments: ${{ matrix.clang-version == '12' && 'true' || 'false' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml index 299c567..926e443 100644 --- a/.github/workflows/cpp-lint-package.yml +++ b/.github/workflows/cpp-lint-package.yml @@ -1,13 +1,12 @@ name: cpp-linter as pkg on: - # workflow_dispatch: - # inputs: - # branch: - # description: 'which branch to test' - # default: 'main' - # required: true - pull_request: + workflow_dispatch: + inputs: + branch: + description: 'which branch to test' + default: 'main' + required: true jobs: cpp-linter: From 152813f472ad99626b41fbbda744e16dd26ded9b Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 13:17:48 -0800 Subject: [PATCH 20/28] only post comments from linux runner --- .github/workflows/cpp-lint-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index d1d1876..a0341d2 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -44,7 +44,7 @@ jobs: database: build verbosity: 9 version: ${{ matrix.clang-version }} - thread-comments: ${{ matrix.clang-version == '12' && 'true' || 'false' }} + thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'true' || 'false' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall From 3915a4c74621c5b0a096cc69480ffbd2e3a3407d Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 13:52:06 -0800 Subject: [PATCH 21/28] update comment; yes-lgtm; only changed files --- .github/workflows/cpp-lint-action.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index a0341d2..a2b9b06 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -38,15 +38,16 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: style: file - files-changed-only: false + files-changed-only: true # to ignore all build folder contents ignore: build database: build verbosity: 9 version: ${{ matrix.clang-version }} - thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'true' || 'false' }} + thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' || 'false' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall + no-lgtm: false - name: Fail fast?! # if: steps.linter.outputs.checks-failed > 0 From 8608d6e0a26269f2924adebb1bf8336e2d8e4046 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 15:53:22 -0800 Subject: [PATCH 22/28] all files; yes-lgtm; update comment --- .github/workflows/cpp-lint-action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index a2b9b06..c5e634e 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -38,13 +38,13 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: style: file - files-changed-only: true + files-changed-only: false # to ignore all build folder contents ignore: build database: build verbosity: 9 version: ${{ matrix.clang-version }} - thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' || 'false' }} + thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall no-lgtm: false From 519286d29b2da36f8f6b7ea453da9652a76de375 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 15:57:11 -0800 Subject: [PATCH 23/28] all files; anew comment; yes-lgtm --- .github/workflows/cpp-lint-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index c5e634e..bdffa1f 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -44,7 +44,7 @@ jobs: database: build verbosity: 9 version: ${{ matrix.clang-version }} - thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' }} + thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall no-lgtm: false From 267db0726bb1a79fcf76b98ca7e57471c7221e5a Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 15:59:28 -0800 Subject: [PATCH 24/28] changed files; anew comment; yes-lgtm --- .github/workflows/cpp-lint-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index bdffa1f..911af5a 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -38,7 +38,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: style: file - files-changed-only: false + files-changed-only: true # to ignore all build folder contents ignore: build database: build From dd0980e2eb784f42b3d8c645a6638d4aa4b5e048 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 16:02:26 -0800 Subject: [PATCH 25/28] changed files; anew comment; no-lgtm --- .github/workflows/cpp-lint-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index 911af5a..d330aff 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -47,7 +47,7 @@ jobs: thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall - no-lgtm: false + no-lgtm: true - name: Fail fast?! # if: steps.linter.outputs.checks-failed > 0 From dd0240990b5d6be2f3f7724f78260f795b47f1b4 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 16:05:03 -0800 Subject: [PATCH 26/28] all files; update comment; no-lgtm --- .github/workflows/cpp-lint-action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index d330aff..3412d55 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -38,13 +38,13 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: style: file - files-changed-only: true + files-changed-only: false # to ignore all build folder contents ignore: build database: build verbosity: 9 version: ${{ matrix.clang-version }} - thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' }} + thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall no-lgtm: true From f5ff2f26591a8b50dd49304597d16171160b7cf8 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 16:07:37 -0800 Subject: [PATCH 27/28] changed files; update comment; yes-lgtm --- .github/workflows/cpp-lint-action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index 3412d55..920a6cb 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -38,7 +38,7 @@ jobs: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: style: file - files-changed-only: false + files-changed-only: true # to ignore all build folder contents ignore: build database: build @@ -47,7 +47,7 @@ jobs: thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall - no-lgtm: true + no-lgtm: false - name: Fail fast?! # if: steps.linter.outputs.checks-failed > 0 From cd910f0f027d1d9a968cc4285cce0caf59ce78ab Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Fri, 10 Nov 2023 16:10:06 -0800 Subject: [PATCH 28/28] changed files; update comment; no-lgtm --- .github/workflows/cpp-lint-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp-lint-action.yml b/.github/workflows/cpp-lint-action.yml index 920a6cb..c77a971 100644 --- a/.github/workflows/cpp-lint-action.yml +++ b/.github/workflows/cpp-lint-action.yml @@ -47,7 +47,7 @@ jobs: thread-comments: ${{ matrix.os == 'ubuntu-latest' && matrix.clang-version == '12' && 'update' }} file-annotations: ${{ matrix.clang-version == '12' }} extra-args: -std=c++14 -Wall - no-lgtm: false + no-lgtm: true - name: Fail fast?! # if: steps.linter.outputs.checks-failed > 0