Skip to content

Commit 31a8807

Browse files
deanberrisdeanberris
committed
Adding missing default destructor implementations for request/response bases.
1 parent d9c30d7 commit 31a8807

File tree

8 files changed

+95
-5
lines changed

8 files changed

+95
-5
lines changed

‎boost/network/protocol/http/request/request_base.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,8 @@ struct request_base : message_base, request_storage_base {
6464

6565
} /* boost */
6666

67+
#ifdef BOOST_NETWORK_NO_LIB
68+
#include <boost/network/protocol/http/request/request_base.ipp>
69+
#endif
70+
6771
#endif /* BOOST_NETWORK_PROTOCOL_HTTP_REQUEST_BASE_HPP_20111008 */

‎boost/network/protocol/http/request/request_base.ipp

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
#ifndef BOOST_NETWORK_RPTOCOL_HTTP_REQUEST_BASE_IPP_20111102
2+
#define BOOST_NETWORK_RPTOCOL_HTTP_REQUEST_BASE_IPP_20111102
3+
4+
// Copyright 2011 Dean Michael Berris <dberris@google.com>.
5+
// Copyright 2011 Google, Inc.
6+
// Distributed under the Boost Software License, Version 1.0.
7+
// (See accompanying file LICENSE_1_0.txt or copy at
8+
// http://www.boost.org/LICENSE_1_0.txt)
9+
10+
#include <boost/network/protocol/http/request/request_base.hpp>
11+
12+
namespace boost { namespace network { namespace http {
13+
14+
request_base::~request_base() {
15+
// default implementation, only required for linking.
16+
}
17+
18+
} /* http */
19+
20+
} /* network */
21+
22+
} /* boost */
23+
24+
#endif /* BOOST_NETWORK_RPTOCOL_HTTP_REQUEST_BASE_IPP_20111102 */

‎boost/network/protocol/http/response/response_base.hpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
// (See accompanying file LICENSE_1_0.txt or copy at
88
// http://www.boost.org/LICENSE_1_0.txt)
99

10+
#include <boost/network/message/message_base.hpp>
11+
1012
namespace boost { namespace network { namespace http {
1113

1214
struct response_base : message_base {
@@ -16,12 +18,14 @@ struct response_base : message_base {
1618
virtual ~response_base() = 0;
1719
};
1820

19-
response_base::~response_base() {}
20-
2121
} /* http */
2222

2323
} /* network */
2424

2525
} /* boost */
2626

27+
#ifdef BOOST_NETWORK_NO_LIB
28+
#include <boost/network/protocol/http/response/response_base.ipp>
29+
#endif
30+
2731
#endif /* BOOST_NETWORK_PROTOCOL_HTTP_RESPONSE_BASE_HPP_20110930 */

‎boost/network/protocol/http/response/response_base.ipp

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
#ifndef BOOST_NETWORK_PROTOCOL_HTTP_RESPONSE_RESPONSE_BASE_IPP_20111102
2+
#define BOOST_NETWORK_PROTOCOL_HTTP_RESPONSE_RESPONSE_BASE_IPP_20111102
3+
4+
// Copyright 2011 Dean Michael Berris <dberris@google.com>.
5+
// Copyright 2011 Google, Inc.
6+
// Distributed under the Boost Software License, Version 1.0.
7+
// (See accompanying file LICENSE_1_0.txt or copy at
8+
// http://www.boost.org/LICENSE_1_0.txt)
9+
10+
#include <boost/network/protocol/http/response/response_base.hpp>
11+
12+
namespace boost { namespace network { namespace http {
13+
14+
response_base::~response_base() {
15+
// default implementation, required only for linking.
16+
}
17+
18+
} /* http */
19+
} /* network */
20+
21+
} /* boost */
22+
23+
#endif /* BOOST_NETWORK_PROTOCOL_HTTP_RESPONSE_RESPONSE_BASE_IPP_20111102 */

‎libs/network/src/http/request.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
// Copyright 2011 Dean Michael Berris <dberris@google.com>.
2+
// Copyright 2011 Google, Inc.
3+
// Distributed under the Boost Software License, Version 1.0.
4+
// (See accompanying file LICENSE_1_0.txt or copy at
5+
// http://www.boost.org/LICENSE_1_0.txt)
6+
7+
#ifdef BOOST_NETWORK_NO_LIB
8+
#undef BOOST_NETWORK_NO_LIB
9+
#endif
10+
11+
#include <boost/network/protocol/http/request/request_base.ipp>

‎libs/network/src/http/response.cpp

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
// Copyright 2011 Dean Michael Berris <dberris@google.com>.
2+
// Copyright 2011 Google, Inc.
3+
// Distributed under the Boost Software License, Version 1.0.
4+
// (See accompanying file LICENSE_1_0.txt or copy at
5+
// http://www.boost.org/LICENSE_1_0.txt)
6+
7+
#ifdef BOOST_NETWORK_NO_LIB
8+
#undef BOOST_NETWORK_NO_LIB
9+
#endif
10+
11+
#include <boost/network/protocol/http/response/response_base.ipp>

‎libs/network/test/http/CMakeLists.txt

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,18 @@ if (Boost_FOUND)
3131
PROPERTIES COMPILE_FLAGS "-Wall")
3232
endif()
3333
add_executable(cpp-netlib-http-${test} ${test}.cpp)
34-
add_dependencies(cpp-netlib-http-${test} cppnetlib-uri)
35-
target_link_libraries(cpp-netlib-http-${test} ${Boost_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT} cppnetlib-uri cppnetlib-client-connections)
34+
add_dependencies(cpp-netlib-http-${test}
35+
cppnetlib-uri
36+
cppnetlib-message
37+
cppnetlib-http-message
38+
cppnetlib-client-connections)
39+
target_link_libraries(cpp-netlib-http-${test}
40+
${Boost_LIBRARIES}
41+
${CMAKE_THREAD_LIBS_INIT}
42+
cppnetlib-uri
43+
cppnetlib-message
44+
cppnetlib-http-message
45+
cppnetlib-client-connections)
3646
if (OPENSSL_FOUND)
3747
target_link_libraries(cpp-netlib-http-${test} ${OPENSSL_LIBRARIES})
3848
endif()

‎libs/network/test/uri/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ if (Boost_FOUND)
2222
PROPERTIES COMPILE_FLAGS "-Wall")
2323
add_executable(cpp-netlib-${test} ${test}.cpp)
2424
add_dependencies(cpp-netlib-${test} cppnetlib-uri)
25-
target_link_libraries(cpp-netlib-${test} ${Boost_LIBRARIES} ${CMAKE_THREAD_LIBS_INIT} cppnetlib-uri)
25+
target_link_libraries(cpp-netlib-${test}
26+
${Boost_LIBRARIES}
27+
${CMAKE_THREAD_LIBS_INIT}
28+
cppnetlib-uri)
2629
if (OPENSSL_FOUND)
2730
target_link_libraries(cpp-netlib-${test} ${OPENSSL_LIBRARIES})
2831
endif()

0 commit comments

Comments
 (0)