fix port parsing for odd # of digits

yhager · yhager · commit 86d00201e829 · 2017-06-30T13:00:10.000-07:00
diff --git a/src/detail/uri_parse.cpp b/src/detail/uri_parse.cpp
@@ -316,6 +316,7 @@ bool parse(string_view::const_iterator &it, string_view::const_iterator last,
       else if (!isdigit(it, last)) {
         return false;
       }
+      continue;
     }
     else if (hp_state == hier_part_state::path) {
       if (*it == '?') {
diff --git a/test/uri_parse_test.cpp b/test/uri_parse_test.cpp
@@ -125,6 +125,13 @@ TEST(uri_parse_test, test_hierarchical_part_valid_host_valid_port_empty_path) {
   ASSERT_TRUE(uri.path().empty());
 }
 
+TEST(uri_parse_test, test_hierarchical_part_valid_user_odd_digits_port) {
+  test::uri uri("http://user@www.example.com:12345/foo");
+  EXPECT_TRUE(uri.parse_uri());
+  ASSERT_TRUE(uri.has_port());
+  EXPECT_EQ("12345", uri.port());
+}
+
 TEST(uri_parse_test, test_hierarchical_part_valid_host_port_path) {
   test::uri uri("http://www.example.com:80/path");
   EXPECT_TRUE(uri.parse_uri());

Original file line number	Diff line number	Diff line change
`@@ -316,6 +316,7 @@ bool parse(string_view::const_iterator &it, string_view::const_iterator last,`
`316`	`316`	`else if (!isdigit(it, last)) {`
`317`	`317`	`return false;`
`318`	`318`	`}`
	`319`	`+ continue;`
`319`	`320`	`}`
`320`	`321`	`else if (hp_state == hier_part_state::path) {`
`321`	`322`	`if (*it == '?') {`