Log spam

driesvints · driesvints · commit ebdfdec615ff · 2015-04-12T17:29:49.000+02:00
diff --git a/app/Lio/Forum/Threads/ThreadCreator.php b/app/Lio/Forum/Threads/ThreadCreator.php
@@ -3,6 +3,7 @@
 use Illuminate\Support\MessageBag;
 use Lio\Accounts\User;
 use Lio\Content\SpamDetector;
+use Psr\Log\LoggerInterface;
 
 /**
 * This class can call the following methods on the listener object:
@@ -22,14 +23,21 @@ class ThreadCreator
      */
     private $spamDetector;
 
+    /**
+     * @var \Psr\Log\LoggerInterface
+     */
+    private $logger;
+
     /**
      * @param \Lio\Forum\Threads\ThreadRepository $threads
      * @param \Lio\Content\SpamDetector $spamDetector
+     * @param \Psr\Log\LoggerInterface $logger
      */
-    public function __construct(ThreadRepository $threads, SpamDetector $spamDetector)
+    public function __construct(ThreadRepository $threads, SpamDetector $spamDetector, LoggerInterface $logger)
     {
         $this->threads = $threads;
         $this->spamDetector = $spamDetector;
+        $this->logger = $logger;
     }
 
     // an additional validator is optional and will be run first, an example of a usage for
@@ -39,6 +47,7 @@ public function create(ThreadCreatorListener $listener, $data, $validator = null
         if ($validator && ! $validator->isValid()) {
             return $listener->threadCreationError($validator->getErrors());
         }
+
         return $this->createValidRecord($listener, $data);
     }
 
@@ -59,6 +68,8 @@ private function getNew($data)
     private function validateAndSave($thread, $listener, $data)
     {
         if ($this->spamDetector->detectsSpam($thread->subject)) {
+            $this->logSpam($thread->subject, $thread->author);
+
             $this->increaseUserSpamCount($thread->author);
 
             return $listener->threadCreationError(
@@ -67,6 +78,8 @@ private function validateAndSave($thread, $listener, $data)
         }
 
         if ($this->spamDetector->detectsSpam($thread->body)) {
+            $this->logSpam($thread->body, $thread->author);
+
             $this->increaseUserSpamCount($thread->author);
 
             return $listener->threadCreationError(
@@ -103,4 +116,14 @@ private function increaseUserSpamCount(User $user)
 
         $user->save();
     }
+
+    /**
+     * @param string $spam
+     * @param \Lio\Accounts\User $author
+     */
+    private function logSpam($spam, User $author)
+    {
+        $this->logger->warning("Warning: attempted spam posted by [#{$author->id}] {$author->name}:");
+        $this->logger->warning($spam);
+    }
 }
