Skip to content

feat(deps): remove node.js 18 #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

MikeMcC399
Copy link
Collaborator

Situation

Node.js 18.x transitioned into End-of-life status on Apr 30, 2025.

Change

This PR removes Node.js 18:

The section README > wait-on with Node.js 18+ is removed. This section describes workarounds which some environments needed to implement after the introduction of dns changes in Node.js 17.x where the verbatim option defaulted to true in dns.lookup() - meaning that IPv4 addresses were not automatically placed first. There are no longer significant numbers of users reporting that they are encountering these issues, so leaving this section in place is more likely to confuse than to assist.

Comments

  • Although there is no change to the action itself, this PR triggers a minor version release in order to republish the README to the npm registry for reference.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added documentation Improvements or additions to documentation type: dependencies tests labels Apr 30, 2025
@MikeMcC399 MikeMcC399 self-assigned this Apr 30, 2025
@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review April 30, 2025 06:16
@jennifer-shehane
Copy link
Member

@MikeMcC399 Is it technically EOL if they haven’t done an EOL release? Genuinely asking since I know they’re off schedule for the 24 release. https://github.com/nodejs/release?tab=readme-ov-file#end-of-life-releases

@MikeMcC399
Copy link
Collaborator Author

@jennifer-shehane

Is it technically EOL if they haven’t done an EOL release?

There is no further release planned for Node.js 18.x, and the end-of-life is being announced on their website.

image

Based on past experience it can take a day or two until all the pages have been updated to be consistent, so I'd expect to see this by May 1 or May 2, 2025.

If you don't feel comfortable merging this PR today, you can delay a day or two. I don't have a problem with that.

Genuinely asking since I know they’re off schedule for the 24 release. https://github.com/nodejs/release?tab=readme-ov-file#end-of-life-releases

I've been following this, and there has never been any suggestion to delay EOL for Node.js 18 due to the delay of the Node.js 24 release.

The problem with Node.js 24 is the integration with V8 13.6. They seem to be getting closer to resolving the issues, however they have not announced any new target date for the 24 release. It's on the agenda tomorrow May 1, 2025 for the release working group.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link
Collaborator Author

https://nodejs.org/en announces:

image

@MikeMcC399
Copy link
Collaborator Author

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Missed the announcement page.

@jennifer-shehane jennifer-shehane merged commit 6d4f8f5 into cypress-io:master Apr 30, 2025
75 checks passed
Copy link

🎉 This PR is included in version 6.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MikeMcC399 MikeMcC399 deleted the remove/node-18 branch May 1, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation released tests type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants