chore(client): update func definition to be clearer #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 26 26
Lines 1503 1503
=======================================
Hits 1002 1002
Misses 415 415
Partials 86 86
Continue to review full report at Codecov.
|
Signed-off-by: Josh Dando <joshdando@Joshs-MacBook-Pro.local>
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started playing around with dapr and had a slight issue as I followed the docs on the main website which suggested running dapr with:
dapr run --app-id myapp --dapr-http-port 3500.When it came to creating the client I assumed I could use
dapr.NewClientWithPort("3500")but upon further investigation I saw it's internally using a gRPC port. I think we should make it a bit clearer to the reader.