Add Dogstatsd metrics for both duplicate and blank events.

darron · darron · commit cf6944697357 · 2015-11-28T19:14:51.000-07:00
diff --git a/commands/dogstatsd.go b/commands/dogstatsd.go
@@ -31,3 +31,29 @@ func StatsdRunTime(start time.Time, exec string, watchType string, watchId strin
 		statsd.Gauge(metricName, float64(milliseconds), tags)
 	}
 }
+
+func StatsdDuplicate(watchType string, watchId string) {
+	if DogStatsd {
+		statsd, _ := godspeed.NewDefault()
+		defer statsd.Conn.Close()
+		tags := make([]string, 2)
+		watchTypeTag := fmt.Sprintf("watchtype:%s", watchType)
+		watchIdTag := fmt.Sprintf("watchid:%s", watchId)
+		tags = append(tags, watchTypeTag)
+		tags = append(tags, watchIdTag)
+		metricName := fmt.Sprintf("%s.duplicate", MetricPrefix)
+		statsd.Incr(metricName, tags)
+	}
+}
+
+func StatsdBlank(watchType string) {
+	if DogStatsd {
+		statsd, _ := godspeed.NewDefault()
+		defer statsd.Conn.Close()
+		tags := make([]string, 1)
+		watchTypeTag := fmt.Sprintf("watchtype:%s", watchType)
+		tags = append(tags, watchTypeTag)
+		metricName := fmt.Sprintf("%s.blank", MetricPrefix)
+		statsd.Incr(metricName, tags)
+	}
+}
diff --git a/commands/event.go b/commands/event.go
@@ -44,12 +44,12 @@ func startEvent(cmd *cobra.Command, args []string) {
 			StatsdRunTime(start, Exec, "event", EventName, strconv.FormatInt(lTime, 10))
 		} else {
 			RunTime(start, "duplicate", fmt.Sprintf("watch='event' exec='%s' ltime='%d'", Exec, lTime))
+			StatsdDuplicate("event", EventName)
 		}
-
 	} else {
 		RunTime(start, "blank", fmt.Sprintf("watch='event' exec='%s'", Exec))
+		StatsdBlank("event")
 	}
-
 }
 
 func checkEventFlags() {
diff --git a/commands/key.go b/commands/key.go
@@ -40,9 +40,11 @@ func startKey(cmd *cobra.Command, args []string) {
 			StatsdRunTime(start, Exec, "key", d.getKey(), shaValue)
 		} else {
 			RunTime(start, "duplicate", fmt.Sprintf("watch='key' exec='%s' sha='%s'", Exec, shaValue))
+			StatsdDuplicate("key", d.getKey())
 		}
 	} else {
 		RunTime(start, "blank", fmt.Sprintf("watch='key' exec='%s'", Exec))
+		StatsdBlank("key")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -44,12 +44,12 @@ func startEvent(cmd *cobra.Command, args []string) {`
`44`	`44`	`StatsdRunTime(start, Exec, "event", EventName, strconv.FormatInt(lTime, 10))`
`45`	`45`	`} else {`
`46`	`46`	`RunTime(start, "duplicate", fmt.Sprintf("watch='event' exec='%s' ltime='%d'", Exec, lTime))`
	`47`	`+ StatsdDuplicate("event", EventName)`
`47`	`48`	`}`
`48`		`-`
`49`	`49`	`} else {`
`50`	`50`	`RunTime(start, "blank", fmt.Sprintf("watch='event' exec='%s'", Exec))`
	`51`	`+ StatsdBlank("event")`
`51`	`52`	`}`
`52`		`-`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`func checkEventFlags() {`
Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,11 @@ func startKey(cmd *cobra.Command, args []string) {`
`40`	`40`	`StatsdRunTime(start, Exec, "key", d.getKey(), shaValue)`
`41`	`41`	`} else {`
`42`	`42`	`RunTime(start, "duplicate", fmt.Sprintf("watch='key' exec='%s' sha='%s'", Exec, shaValue))`
	`43`	`+ StatsdDuplicate("key", d.getKey())`
`43`	`44`	`}`
`44`	`45`	`} else {`
`45`	`46`	`RunTime(start, "blank", fmt.Sprintf("watch='key' exec='%s'", Exec))`
	`47`	`+ StatsdBlank("key")`
`46`	`48`	`}`
`47`	`49`	`}`
`48`	`50`