Skip to content

MAINT: various refactoring #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Conversation

lucascolley
Copy link
Member

No description provided.

@lucascolley lucascolley marked this pull request as ready for review January 19, 2025 16:07
@lucascolley lucascolley added the maintenance general maintenance label Jan 19, 2025
@lucascolley lucascolley changed the title MAINT: refactor at to separate file MAINT: various refactoring Jan 19, 2025
@lucascolley lucascolley merged commit 10996a3 into data-apis:main Jan 19, 2025
10 checks passed
@crusaderky
Copy link
Contributor

This PR makes it impossible to have a line with import jax and run the linters on it on Windows, where there are no JAX builds available yet.

@crusaderky
Copy link
Contributor

crusaderky commented Jan 20, 2025

It also makes running pixi run -e lint lint a very long affair after every time you need to wipe your mypy cache. Which, thanks to based-mypy's bugs, I find myself doing on a regular basis.

[EDIT] correction, it makes it impossibly long every time.

@lucascolley
Copy link
Member Author

lucascolley commented Jan 20, 2025

Ah, very good point, sorry about that.

I think we should be able to fallback to JAX from PyPI on windows.

If the times are too long then maybe it is better to revert to using import ignores, though.

@crusaderky
Copy link
Contributor

If the times are too long then maybe it is better to revert to using import ignores, though.

Yes please.

@lucascolley
Copy link
Member Author

For some context, my motivation was getting the lint task to work in the dev env. If we can isolate the lint feature to just the lint env, that may be unnecessary.

@crusaderky
Copy link
Contributor

Ah yes, I've been fruitlessly trying to skip the mandatory -e lint too.

@lucascolley lucascolley deleted the refactor1 branch January 20, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance general maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants