Bound test_full fill values to default dtypes
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. It would be nice if we had a library that defaulted to float32 to test this against. Does NumPy default to 32-bit types when compiled 32-bit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our test suite can fail for
test_full(depending on the Hypothesis seed or max examples) because I didn't boundfill_valuegeneration to the bounds of the default dtypes. This PR fixes that by inferring the default int and float indtype_helpers, and using that to prevent passing dtypes with values that cannot be represented by the default dtypes.This should be useful for the future too.