-
Notifications
You must be signed in to change notification settings - Fork 36
lz4 dependency is causing install issues for our users #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@archiewood thank you for reporting. I'd also prefer any native LZ4 library, but unfortunately there's basically no choice: |
Thanks for the fast response. I think this approach would work for us |
Hi @archiewood! We just released v1.8.4 where |
Have you had anyone report issues with this? I'm receiving this error when running 1.8.4:
|
Hi @szsori! This doesn't look like a NPM or Yarn error - do you use any bundler maybe? If yes - please share its configuration to help me to reproduce your issue |
@kravets-levko We're on NextJS 14, which uses webpack 5 (we haven't switched to turbo yet). Here is the relevant area of our config:
Our package.json looks like:
|
Thank you @szsori! I think this is enough to reproduce your issue. I will try to do it ASAP, and will get back to you. If you (by any chance) will figure it out yourself - please let me know so we can fix the library, or even submit a PR 🙂 |
@kravets-levko This is in our next.config.js as well, but removing it doesn't resolve the issue. This was to resolve a separate nextjs issue detailed here: vercel/next.js#62193. Just to be clear, everything still works... we're just getting errors in the console.
|
Even on hosts that do have all dependencies installed, LZ4 sometimes fails to compile for no obvious reason. We have a CI pipeline that usually passes but occasionally fails. We have not yet invested any time into investigating this, but I'm sharing it as a kind of warning sign. It's worth noting that the LZ4 repository
|
Hi! I'm having the same problem using Next.js 14 and @databricks/sql 1.8.4. Is there any solution yet? package.json
@/lib/databricks.ts `import { DBSQLClient } from "@databricks/sql" export class DatabricksConnection { private constructor() {} public static getInstance(): DatabricksConnection { public async testConnection(): Promise<{
} API endpoint to test connetion: export const dynamic = "force-dynamic" export async function GET(request: NextRequest) { if (connectionResult.success) { When I send GET request to /api/databricks, I get this log: ` ○ Compiling /api/databricks ... Import trace for requested module: ./node_modules/ws/lib/buffer-util.js Import trace for requested module: ./node_modules/ws/lib/validation.js Import trace for requested module: |
A recent version of this connector, 1.8.0 introduced lz4 compression #216
We recently upgraded from <1.8.0 to 1.8.3 and we have since then had several reports from users about being unable to install our library.
Here is an example, but i'd say we've had c.10-20 reports of this in the last 3 weeks: evidence-dev/evidence#1885
The crux of the issue seems to be that lz4 is building from source, and this requires a number of pieces of software to be installed on a client's machine that they do not always have, and didn't previously need:
make
,visual studio build tools
etc.For the moment, I'm intending on resolving this by downgrading our Databricks dependency to 1.7.x but I thought it might be useful for your team to know.
The text was updated successfully, but these errors were encountered: