Merge pull request RustPython#1580 from seeeturtle/doc-f

palaviv · web-flow · commit 72989cdfd12b · 2019-11-02T19:18:11.000+02:00
Set docstring of function as None if not declared
diff --git a/compiler/src/compile.rs b/compiler/src/compile.rs
@@ -1015,22 +1015,23 @@ impl<O: OutputStream> Compiler<O> {
     }
 
     fn store_docstring(&mut self, doc_str: Option<String>) {
-        if let Some(doc_string) = doc_str {
-            // Duplicate top of stack (the function or class object)
-            self.emit(Instruction::Duplicate);
+        // Duplicate top of stack (the function or class object)
+        self.emit(Instruction::Duplicate);
 
-            // Doc string value:
-            self.emit(Instruction::LoadConst {
-                value: bytecode::Constant::String {
-                    value: doc_string.to_string(),
+        // Doc string value:
+        self.emit(Instruction::LoadConst {
+            value: match doc_str {
+                Some(doc) => bytecode::Constant::String {
+                    value: doc.to_string(),
                 },
-            });
+                None => bytecode::Constant::None, // set docstring None if not declared
+            },
+        });
 
-            self.emit(Instruction::Rotate { amount: 2 });
-            self.emit(Instruction::StoreAttr {
-                name: "__doc__".to_string(),
-            });
-        }
+        self.emit(Instruction::Rotate { amount: 2 });
+        self.emit(Instruction::StoreAttr {
+            name: "__doc__".to_string(),
+        });
     }
 
     fn compile_while(
diff --git a/tests/snippets/function.py b/tests/snippets/function.py
@@ -95,3 +95,8 @@ def f8() -> int:
 
 with assert_raises(SyntaxError):
     exec('print(keyword=10, 20)')
+
+def f9():
+    pass
+
+assert f9.__doc__ == None
