Set a cap on the content bufffer to prevent frivolous resizing

ysimonson · ysimonson · commit 4aed38e09c20 · 2013-07-22T00:35:32.000-04:00
diff --git a/server.go b/server.go
@@ -328,7 +328,7 @@ func (s *Server) logRequest(ctx Context, sTime time.Time) {
 func (s *Server) routeHandler(req *http.Request, w http.ResponseWriter) (unused *route) {
     routeHit := false
     requestPath := req.URL.Path
-    allContent := make([][]byte, 0)
+    allContent := make([][]byte, 0, 2)
     ctx := Context{req, map[string]string{}, s, w, false}
 
     finishResponse := func() {
@@ -364,8 +364,8 @@ func (s *Server) routeHandler(req *http.Request, w http.ResponseWriter) (unused
         }
     }
 
-    defer s.logRequest(ctx, tm)
     defer finishResponse()
+    defer s.logRequest(ctx, tm)
 
     ctx.SetHeader("Date", webTime(tm), true)
 

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ func (s *Server) logRequest(ctx Context, sTime time.Time) {`
`328`	`328`	`func (s Server) routeHandler(req http.Request, w http.ResponseWriter) (unused *route) {`
`329`	`329`	`routeHit := false`
`330`	`330`	`requestPath := req.URL.Path`
`331`		`- allContent := make([][]byte, 0)`
	`331`	`+ allContent := make([][]byte, 0, 2)`
`332`	`332`	`ctx := Context{req, map[string]string{}, s, w, false}`
`333`	`333`
`334`	`334`	`finishResponse := func() {`
`@@ -364,8 +364,8 @@ func (s Server) routeHandler(req http.Request, w http.ResponseWriter) (unused`
`364`	`364`	`}`
`365`	`365`	`}`
`366`	`366`
`367`		`- defer s.logRequest(ctx, tm)`
`368`	`367`	`defer finishResponse()`
	`368`	`+ defer s.logRequest(ctx, tm)`
`369`	`369`
`370`	`370`	`ctx.SetHeader("Date", webTime(tm), true)`
`371`	`371`