Context.HasParam renamed to Contetx.GetParam . This either returns an empty string, or the first param for the name

Michael Hoisie · Michael Hoisie · commit a34464483269 · 2010-02-17T11:25:45.000-08:00
Head requests now receive url params Params
diff --git a/request.go b/request.go
@@ -138,7 +138,7 @@ func (r *Request) parseParams() (err os.Error) {
 
     var query string
     switch r.Method {
-    case "GET":
+    case "GET", "HEAD":
         query = r.URL.RawQuery
     case "POST":
         if r.Body == nil {
@@ -253,13 +253,18 @@ func (r *Request) parseCookies() (err os.Error) {
     return nil
 }
 
-func (r *Request) HasParam(name string) bool {
+//Returns the first parameter given a name, or an empty string
+func (r *Request) GetParam(name string) string {
     if r.Params == nil || len(r.Params) == 0 {
-        return false
+        return ""
     }
-    _, ok := r.Params[name]
-    return ok
+    params, ok := r.Params[name]
+    if !ok  || len(params) == 0 {
+	return ""
+    }
+    return params[0]
 }
+
 func (r *Request) HasFile(name string) bool {
     if r.Files == nil || len(r.Files) == 0 {
         return false
diff --git a/web_test.go b/web_test.go
@@ -80,7 +80,6 @@ func buildTestResponse(buf *bytes.Buffer) *testResponse {
 }
 
 func getTestResponse(method string, path string, body string, headers map[string]string) *testResponse {
-
     req := buildTestRequest(method, path, body, headers)
     var buf bytes.Buffer
 
@@ -137,6 +136,7 @@ func init() {
         }
         return val
     })
+    Get("/getparam", func(ctx *Context) string { return ctx.GetParam("a") })
 }
 
 var tests = []Test{
@@ -157,6 +157,8 @@ var tests = []Test{
     Test{"POST", "/doesnotexist", "", 404, "Page not found"},
     Test{"GET", "/error/code/500", "", 500, statusText[500]},
     Test{"POST", "/posterror/code/410/failedrequest", "", 410, "failedrequest"},
+    Test{"GET", "/getparam?a=abcd", "", 200, "abcd"},
+    Test{"GET", "/getparam?b=abcd", "", 200, ""},
 }
 
 func buildTestRequest(method string, path string, body string, headers map[string]string) *Request {

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ func buildTestResponse(buf bytes.Buffer) testResponse {`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`func getTestResponse(method string, path string, body string, headers map[string]string) *testResponse {`
`83`		`-`
`84`	`83`	`req := buildTestRequest(method, path, body, headers)`
`85`	`84`	`var buf bytes.Buffer`
`86`	`85`
`@@ -137,6 +136,7 @@ func init() {`
`137`	`136`	`}`
`138`	`137`	`return val`
`139`	`138`	`})`
	`139`	`+ Get("/getparam", func(ctx *Context) string { return ctx.GetParam("a") })`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	`var tests = []Test{`
`@@ -157,6 +157,8 @@ var tests = []Test{`
`157`	`157`	`Test{"POST", "/doesnotexist", "", 404, "Page not found"},`
`158`	`158`	`Test{"GET", "/error/code/500", "", 500, statusText[500]},`
`159`	`159`	`Test{"POST", "/posterror/code/410/failedrequest", "", 410, "failedrequest"},`
	`160`	`+ Test{"GET", "/getparam?a=abcd", "", 200, "abcd"},`
	`161`	`+ Test{"GET", "/getparam?b=abcd", "", 200, ""},`
`160`	`162`	`}`
`161`	`163`
`162`	`164`	`func buildTestRequest(method string, path string, body string, headers map[string]string) *Request {`