From a45797aef9ee6bb92325891004b1b4344dd678bd Mon Sep 17 00:00:00 2001 From: dcode Date: Tue, 18 Feb 2025 21:56:00 +0100 Subject: [PATCH 1/2] Update dependency --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index a1fd88b..6b350a3 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.0.0", "license": "Apache-2.0", "devDependencies": { - "esm2umd": "^0.3.0", + "esm2umd": "^0.3.1", "prettier": "^3.5.0", "typescript": "^5.7.3" } @@ -426,9 +426,9 @@ } }, "node_modules/esm2umd": { - "version": "0.3.0", - "resolved": "https://registry.npmjs.org/esm2umd/-/esm2umd-0.3.0.tgz", - "integrity": "sha512-dHcmK+4D2thL27HUz8UazgPqIIJARj+whPF/Wr5zraqlCe54UpPIFsg1wKRJEZK/BCmq6jPMqTtYBTXHz9j01A==", + "version": "0.3.1", + "resolved": "https://registry.npmjs.org/esm2umd/-/esm2umd-0.3.1.tgz", + "integrity": "sha512-5WcGtkITdTHoLSkM/ZGWgsieCvlPUJLJdGOAmnmXPjjNBU/lwMGg3D4Tx/FWe32pY0ZhhAwoM8Oy+1hBI7BKQg==", "dev": true, "license": "MIT", "dependencies": { @@ -871,9 +871,9 @@ "dev": true }, "esm2umd": { - "version": "0.3.0", - "resolved": "https://registry.npmjs.org/esm2umd/-/esm2umd-0.3.0.tgz", - "integrity": "sha512-dHcmK+4D2thL27HUz8UazgPqIIJARj+whPF/Wr5zraqlCe54UpPIFsg1wKRJEZK/BCmq6jPMqTtYBTXHz9j01A==", + "version": "0.3.1", + "resolved": "https://registry.npmjs.org/esm2umd/-/esm2umd-0.3.1.tgz", + "integrity": "sha512-5WcGtkITdTHoLSkM/ZGWgsieCvlPUJLJdGOAmnmXPjjNBU/lwMGg3D4Tx/FWe32pY0ZhhAwoM8Oy+1hBI7BKQg==", "dev": true, "requires": { "@babel/core": "^7.26.8", diff --git a/package.json b/package.json index b09677b..1b8bee1 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "README.md" ], "devDependencies": { - "esm2umd": "^0.3.0", + "esm2umd": "^0.3.1", "prettier": "^3.5.0", "typescript": "^5.7.3" } From e1bcb4f65096465b69f0fd67e68fc2a79a67ade9 Mon Sep 17 00:00:00 2001 From: dlizewski Date: Thu, 17 Apr 2025 13:30:30 -0400 Subject: [PATCH 2/2] fix: Call correct function when using Long.fromValue with a bigInt (#134) --- index.js | 2 +- tests/index.js | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/index.js b/index.js index 9a0fe70..4983233 100644 --- a/index.js +++ b/index.js @@ -1562,7 +1562,7 @@ if (typeof BigInt === "function") { // Override Long.fromValue = function fromValueWithBigInt(value, unsigned) { - if (typeof value === "bigint") return fromBigInt(value, unsigned); + if (typeof value === "bigint") return Long.fromBigInt(value, unsigned); return fromValue(value, unsigned); }; diff --git a/tests/index.js b/tests/index.js index 56ba76c..3eab85e 100644 --- a/tests/index.js +++ b/tests/index.js @@ -267,6 +267,15 @@ var tests = [ assert.strictEqual(unsignedFromUnsigned.toBigInt(), values[i].unsigned); var signedFromUnsigned = Long.fromBigInt(values[i].unsigned); assert.strictEqual(signedFromUnsigned.toBigInt(), values[i].signed); + + var signedFromSigned = Long.fromValue(values[i].signed); + assert.strictEqual(signedFromSigned.toBigInt(), values[i].signed); + var unsignedFromSigned = Long.fromValue(values[i].signed, true); + assert.strictEqual(unsignedFromSigned.toBigInt(), values[i].unsigned); + var unsignedFromUnsigned = Long.fromValue(values[i].unsigned, true); + assert.strictEqual(unsignedFromUnsigned.toBigInt(), values[i].unsigned); + var signedFromUnsigned = Long.fromValue(values[i].unsigned); + assert.strictEqual(signedFromUnsigned.toBigInt(), values[i].signed); } },