Implement nested assemblies navigation #13662
Conversation
|
I think all the ACs are met. Passing the review to @decidim/product |
|
@NilHomedes when you are defining the parent in an assembly, you are shown this:
Maybe we want to replicate the hierarchy in the select, adding -- ie.
|
|
Can you fix the git conflicts 🙏🏽 ? @NilHomedes this is on your plate, right? |
a1170de
There was a problem hiding this comment.
Thanks @mllocs
Awesome nesting! 🪺
Here is my review:
-
As an admin, when I duplicate a child assembly, it is being promoted to the first level. My expected behaviour would be that it is copied at the same level.
So, once I duplicate a child assembly (i.e. level 2), I should see the nested assemblies until level 2 expanded. Then I can easily see the assembly I just copied. -
In that sense. We have seen that the behavior of creating a new assembly should be retrieved:
1/ Create new assembly
2/ Being redirect to the list of assemblies with the assembly you have created visible
3/ if it’s a child assembly, I should see the nested assemblies until the new assembly level expanded -
When duplicating assemblies, we are showing as a heading the breadcrumb of nested assemblies. This should be shown as normal text.
-
As an assembly admin of Level 2 Assembly, I also have permissions in the Level 3 (and even I can duplicate Level 4). What’s the logic behind this? I’m not sure what has been the behaviour since now. From my point of view, if I’m an admin of the Level 2 Assembly, I should have permissions on all their child assemblies.
-
As an admin, when I expand and, after, collapse again a child assembly, then the other first level assemblies disappear from the table. This is happening from a certain level of depth. See video: https://www.awesomescreenshot.com/video/33811933?key=0208c4f431910ee0ab1b5f50ed1e3ff9
-
In the admin panel>Visibility when chosing the parent space I am not seeing the hierachy levels. We shoould do something similar to what we are doing with taxonomies selector.
Taxonomies:
|
Hi @NilHomedes - We have been reviewing with @mllocs and some things seem to be new ACs, that need considerable effort (they are not just fixes), so maybe they need new issues that are sized and planned, because if not we are accumulating extra work and delays (this adds up to the BCN new issues that have been tackled that were out of the sprints, and extra/unexpected things in the Ephemeral development). These are what we see as new ACs and that are not quick to fix:
@mllocs will work on the rest of the things for the time being. |
|
@NilHomedes I fixed two issues, already deployed in staging:
A part from the issues @furilo mentioned, for example, I think the first and the third issues are not directly related to this issue and could be tackled as bug fixes or improvements later. |
|
Okey, let's get rid of this two new ACs for the moment.
We will tackle them in the future. |
c7b1011
Fixed, thanks! Moving this to maintainers review cc @andreslucena @alecslupu |
🎩 What? Why?
Improve navigation through nested assemblies by implementing an accordion list UI.
📌 Related Issues
Resolves #13618
Testing
Navigating through the Admin Assemblies list: https://decidim-lot2.populate.tools/admin/assemblies
📷 Screenshots