Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in some Admin dashboard areas are misaligned #13697

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MariaDascaluPublicis
Copy link

@MariaDascaluPublicis MariaDascaluPublicis commented Nov 26, 2024

🎩 What? Why?

Added display flex and margins to align icons

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Go to admin dashbord to initiatives page and moderations page. Observe the icons.

📷 Screenshots

Please add screenshots of the changes you are proposing

Global Moderation

image

Initiative's committee members

image

♥️ Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupu alecslupu added the type: fix PRs that implement a fix for a bug label Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 27, 2024
Copy link
Contributor

@greenwoodt greenwoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @MariaDascaluPublicis and welcome to Decidim!

Any "Before" screenshots displaying previous functionality that you could help with the review, or a link to an Issue would be fantastic. Otherwise great job and thanks!

….scss

Co-authored-by: Tom Greenwood <101816158+greenwoodt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: admin module: initiatives type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants