Reverse order of compiler list in find compilers dlg

delphidabbler · delphidabbler · commit a2c5f68c1b39 · 2023-07-14T19:42:18.000+01:00
diff --git a/Src/FmFindCompilerDlg.pas b/Src/FmFindCompilerDlg.pas
@@ -55,6 +55,7 @@   TFindCompilerDlg = class(TGenericOKDlg, INoPublicConstruct)
     fSearchParams: TCompilerSearchParams; // Persistent compiler search options
     fSearch: ISearch;                     // Search entered by user
     fRefinePreviousSearch: Boolean;       // Whether to refine previous search
+    fMapIdxToComp: TArray<TCompilerID>;   // Maps list idx to comp ID of entry
 
     procedure UpdateOKBtn;
       {Updates state of OK button according to whether valid entries made in
@@ -363,13 +364,25 @@ procedure TFindCompilerDlg.InitForm;
   Option: TCompilerSearchOption;  // loops thru possible compiler search options
   SelOption: Integer;             // selected search option
   Compiler: ICompiler;            // references each compiler
+  CompID: TCompilerID;
 begin
   inherited;
+  // Set up index map that reverses order of compilers
+  SetLength(fMapIdxToComp, fCompilers.Count);
+  Idx := High(fMapIdxToComp);
+  for CompID := Low(TCompilerID) to High(TCompilerID) do
+  begin
+    fMapIdxToComp[Idx] := CompID;
+    Dec(Idx);
+  end;
+
   // Set up list of compilers and check appropriate ones
   // we store compiler ID in listbox's Objects[] property
-  for Compiler in fCompilers do
+  // Use mapping to reverse order of compilers in list
+  for Idx := Low(fMapIdxToComp) to High(fMapIdxToComp) do
   begin
-    Idx := lbCompilerVers.Items.AddObject(
+    Compiler := fCompilers[fMapIdxToComp[Idx]];
+    lbCompilerVers.Items.AddObject(
       Compiler.GetName, TObject(Compiler.GetID)
     );
     lbCompilerVers.Checked[Idx] := Compiler.GetID in fSearchParams.Compilers;
