C#: Fix the unit tests for ZipSlip #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denislevin
reviewed
Aug 15, 2018
denislevin
pushed a commit
that referenced
this pull request
Jul 22, 2019
CPP: Tests for: Better overflow detection for AssignAdd/AssignSub
denislevin
pushed a commit
that referenced
this pull request
Jul 22, 2019
JavaScript: Remove a few more configurations from AllConfigurations.qll.
denislevin
pushed a commit
that referenced
this pull request
Jul 22, 2019
C++: NonConstantFormat taint only for string types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the tests has failed on your pull request, so I created a fix to save you some time.
The reason that
ZipSlip.csfailed is because the QL tests run on Linux, which always uses .NET Core. So ideally, all tests need to reference assemblies from .NET Core. These are generally available but it can be a little tricky to hunt down the right one.The reason that
TaintedPath.csfailed was because the relative path orSystem.Web.cshas moved. This is a stub file, because that assembly isn't in .NET Core.I also updated the
.expectedtest output since you renamed the source file.