feat: Update API routes to use preValidation instead of preHandler for global admin checks

Lasim · Lasim · commit ce8182788bcc · 2025-07-08T22:02:28.000+02:00
diff --git a/services/backend/api-spec.json b/services/backend/api-spec.json
@@ -6155,6 +6155,17 @@
           "Global Settings"
         ],
         "description": "Tests GitHub App configuration by fetching Microsoft VS Code repository information. Only global administrators can access this endpoint.",
+        "requestBody": {
+          "content": {
+            "application/json": {
+              "schema": {
+                "type": "object",
+                "properties": {},
+                "additionalProperties": true
+              }
+            }
+          }
+        },
         "security": [
           {
             "cookieAuth": []
diff --git a/services/backend/api-spec.yaml b/services/backend/api-spec.yaml
@@ -4287,6 +4287,13 @@ paths:
       description: Tests GitHub App configuration by fetching Microsoft VS Code
         repository information. Only global administrators can access this
         endpoint.
+      requestBody:
+        content:
+          application/json:
+            schema:
+              type: object
+              properties: {}
+              additionalProperties: true
       security:
         - cookieAuth: []
       responses:
diff --git a/services/backend/src/routes/globalSettings/categories/list.ts b/services/backend/src/routes/globalSettings/categories/list.ts
@@ -43,7 +43,7 @@ export default async function listCategoriesRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const categories = await GlobalSettingsService.getCategories();
diff --git a/services/backend/src/routes/globalSettings/github/test-connection.ts b/services/backend/src/routes/globalSettings/github/test-connection.ts
@@ -69,7 +69,7 @@ export default async function githubTestConnectionRoute(fastify: FastifyInstance
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     fastify.log.info({
       operation: 'github_app_test_connection',
diff --git a/services/backend/src/routes/globalSettings/groups/get.ts b/services/backend/src/routes/globalSettings/groups/get.ts
@@ -52,7 +52,7 @@ export default async function getGroupSettingsRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { groupId } = request.params;
diff --git a/services/backend/src/routes/globalSettings/groups/list.ts b/services/backend/src/routes/globalSettings/groups/list.ts
@@ -44,7 +44,7 @@ export default async function listGroupsRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request: FastifyRequest, reply: FastifyReply) => {
     try {
       const groupsWithSettings = await GlobalSettingsService.getAllGroupsWithSettings();
diff --git a/services/backend/src/routes/globalSettings/health/check.ts b/services/backend/src/routes/globalSettings/health/check.ts
@@ -47,7 +47,7 @@ export default async function healthCheckRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const encryptionWorking = validateEncryption();
diff --git a/services/backend/src/routes/globalSettings/settings/bulk.ts b/services/backend/src/routes/globalSettings/settings/bulk.ts
@@ -68,7 +68,7 @@ export default async function bulkGlobalSettingsRoute(fastify: FastifyInstance)
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       // Fastify has already validated request.body using BulkGlobalSettingsSchema
diff --git a/services/backend/src/routes/globalSettings/settings/delete.ts b/services/backend/src/routes/globalSettings/settings/delete.ts
@@ -55,7 +55,7 @@ export default async function deleteGlobalSettingRoute(fastify: FastifyInstance)
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { key } = request.params;
diff --git a/services/backend/src/routes/globalSettings/settings/get.ts b/services/backend/src/routes/globalSettings/settings/get.ts
@@ -57,7 +57,7 @@ export default async function getGlobalSettingRoute(fastify: FastifyInstance) {
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { key } = request.params;
diff --git a/services/backend/src/routes/globalSettings/settings/list.ts b/services/backend/src/routes/globalSettings/settings/list.ts
@@ -44,7 +44,7 @@ export default async function listGlobalSettingsRoute(fastify: FastifyInstance)
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request: FastifyRequest, reply: FastifyReply) => {
     try {
       const settings = await GlobalSettingsService.getAll();
diff --git a/services/backend/src/routes/globalSettings/settings/search.ts b/services/backend/src/routes/globalSettings/settings/search.ts
@@ -57,7 +57,7 @@ export default async function searchGlobalSettingsRoute(fastify: FastifyInstance
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       // Fastify has already validated request.body using SearchGlobalSettingsSchema
diff --git a/services/backend/src/routes/globalSettings/settings/update.ts b/services/backend/src/routes/globalSettings/settings/update.ts
@@ -70,7 +70,7 @@ export default async function updateGlobalSettingRoute(fastify: FastifyInstance)
         })
       }
     },
-    preHandler: requireGlobalAdmin(),
+    preValidation: requireGlobalAdmin(),
   }, async (request, reply) => {
     try {
       const { key } = request.params;

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export default async function listCategoriesRoute(fastify: FastifyInstance) {`
`43`	`43`	`})`
`44`	`44`	`}`
`45`	`45`	`},`
`46`		`- preHandler: requireGlobalAdmin(),`
	`46`	`+ preValidation: requireGlobalAdmin(),`
`47`	`47`	`}, async (request, reply) => {`
`48`	`48`	`try {`
`49`	`49`	`const categories = await GlobalSettingsService.getCategories();`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export default async function githubTestConnectionRoute(fastify: FastifyInstance`
`69`	`69`	`})`
`70`	`70`	`}`
`71`	`71`	`},`
`72`		`- preHandler: requireGlobalAdmin(),`
	`72`	`+ preValidation: requireGlobalAdmin(),`
`73`	`73`	`}, async (request, reply) => {`
`74`	`74`	`fastify.log.info({`
`75`	`75`	`operation: 'github_app_test_connection',`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ export default async function getGroupSettingsRoute(fastify: FastifyInstance) {`
`52`	`52`	`})`
`53`	`53`	`}`
`54`	`54`	`},`
`55`		`- preHandler: requireGlobalAdmin(),`
	`55`	`+ preValidation: requireGlobalAdmin(),`
`56`	`56`	`}, async (request, reply) => {`
`57`	`57`	`try {`
`58`	`58`	`const { groupId } = request.params;`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ export default async function listGroupsRoute(fastify: FastifyInstance) {`
`44`	`44`	`})`
`45`	`45`	`}`
`46`	`46`	`},`
`47`		`- preHandler: requireGlobalAdmin(),`
	`47`	`+ preValidation: requireGlobalAdmin(),`
`48`	`48`	`}, async (request: FastifyRequest, reply: FastifyReply) => {`
`49`	`49`	`try {`
`50`	`50`	`const groupsWithSettings = await GlobalSettingsService.getAllGroupsWithSettings();`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ export default async function healthCheckRoute(fastify: FastifyInstance) {`
`47`	`47`	`})`
`48`	`48`	`}`
`49`	`49`	`},`
`50`		`- preHandler: requireGlobalAdmin(),`
	`50`	`+ preValidation: requireGlobalAdmin(),`
`51`	`51`	`}, async (request, reply) => {`
`52`	`52`	`try {`
`53`	`53`	`const encryptionWorking = validateEncryption();`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ export default async function bulkGlobalSettingsRoute(fastify: FastifyInstance)`
`68`	`68`	`})`
`69`	`69`	`}`
`70`	`70`	`},`
`71`		`- preHandler: requireGlobalAdmin(),`
	`71`	`+ preValidation: requireGlobalAdmin(),`
`72`	`72`	`}, async (request, reply) => {`
`73`	`73`	`try {`
`74`	`74`	`// Fastify has already validated request.body using BulkGlobalSettingsSchema`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ export default async function deleteGlobalSettingRoute(fastify: FastifyInstance)`
`55`	`55`	`})`
`56`	`56`	`}`
`57`	`57`	`},`
`58`		`- preHandler: requireGlobalAdmin(),`
	`58`	`+ preValidation: requireGlobalAdmin(),`
`59`	`59`	`}, async (request, reply) => {`
`60`	`60`	`try {`
`61`	`61`	`const { key } = request.params;`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export default async function getGlobalSettingRoute(fastify: FastifyInstance) {`
`57`	`57`	`})`
`58`	`58`	`}`
`59`	`59`	`},`
`60`		`- preHandler: requireGlobalAdmin(),`
	`60`	`+ preValidation: requireGlobalAdmin(),`
`61`	`61`	`}, async (request, reply) => {`
`62`	`62`	`try {`
`63`	`63`	`const { key } = request.params;`