chore: stabilize light theme (coder#12855)

aslilac · web-flow · commit caa49ea6a1b7 · 2024-04-02T16:06:31.000-06:00
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.stories.tsx b/site/src/modules/dashboard/Navbar/NavbarView.stories.tsx
@@ -25,3 +25,9 @@ export const ForMember: Story = {
     canViewAllUsers: false,
   },
 };
+
+export const CustomLogo: Story = {
+  args: {
+    logo_url: "/icon/github.svg",
+  },
+};
diff --git a/site/src/modules/dashboard/Navbar/NavbarView.tsx b/site/src/modules/dashboard/Navbar/NavbarView.tsx
@@ -13,6 +13,7 @@ import { type FC, type ReactNode, useRef, useState } from "react";
 import { NavLink, useLocation, useNavigate } from "react-router-dom";
 import type * as TypesGen from "api/typesGenerated";
 import { Abbr } from "components/Abbr/Abbr";
+import { ExternalImage } from "components/ExternalImage/ExternalImage";
 import { displayError } from "components/GlobalSnackbar/utils";
 import { CoderIcon } from "components/Icons/CoderIcon";
 import { Latency } from "components/Latency/Latency";
@@ -150,7 +151,7 @@ export const NavbarView: FC<NavbarViewProps> = ({
             <div css={styles.drawerHeader}>
               <div css={[styles.logo, styles.drawerLogo]}>
                 {logo_url ? (
-                  <img src={logo_url} alt="Custom Logo" />
+                  <ExternalImage src={logo_url} alt="Custom Logo" />
                 ) : (
                   <CoderIcon />
                 )}
@@ -167,7 +168,7 @@ export const NavbarView: FC<NavbarViewProps> = ({
 
         <NavLink css={styles.logo} to="/workspaces">
           {logo_url ? (
-            <img src={logo_url} alt="Custom Logo" />
+            <ExternalImage src={logo_url} alt="Custom Logo" />
           ) : (
             <CoderIcon fill="white" opacity={1} width={125} />
           )}
diff --git a/site/src/pages/UserSettingsPage/AppearancePage/AppearanceForm.tsx b/site/src/pages/UserSettingsPage/AppearancePage/AppearanceForm.tsx
@@ -57,7 +57,6 @@ export const AppearanceForm: FC<AppearanceFormProps> = ({
         />
         <ThemePreviewButton
           displayName="Light"
-          preview
           active={currentTheme === "light"}
           theme={themes.light}
           onSelect={() => onChangeTheme("light")}
