Drop childNodes from treebuilder nodes.

gsnedders · gsnedders · commit 7a827bf5edde · 2016-07-12T00:22:29.000+01:00
diff --git a/html5lib/treebuilders/_base.py b/html5lib/treebuilders/_base.py
@@ -28,15 +28,12 @@ def __init__(self, name):
         value - The value of the current node (applies to text nodes and
         comments
         attributes - a dict holding name, value pairs for attributes of the node
-        childNodes - a list of child nodes of the current node. This must
-        include all elements but not necessarily other node types
         _flags - A list of miscellaneous flags that can be set on the node
         """
         self.name = name
         self.parent = None
         self.value = None
         self.attributes = {}
-        self.childNodes = []
         self._flags = []
 
     def __str__(self):
@@ -78,10 +75,7 @@ def reparentChildren(self, newParent):
         This is needed so that trees that don't store text as nodes move the
         text in the correct way
         """
-        # XXX - should this method be made more general?
-        for child in self.childNodes:
-            newParent.appendChild(child)
-        self.childNodes = []
+        raise NotImplementedError
 
     def cloneNode(self):
         """Return a shallow copy of the current node i.e. a node with the same
diff --git a/html5lib/treebuilders/etree.py b/html5lib/treebuilders/etree.py
@@ -142,7 +142,9 @@ def reparentChildren(self, newParent):
                 if self._element.text is not None:
                     newParent._element.text += self._element.text
             self._element.text = ""
-            _base.Node.reparentChildren(self, newParent)
+            for child in self.childNodes:
+                newParent.appendChild(child)
+            self.childNodes = []
 
     class Comment(Element):
         def __init__(self, data):
