DEV: Add tests for about page extra group ordering

Drenmi · Drenmi · commit 75b58b209f7d · 2025-05-28T16:49:39.000+08:00
diff --git a/spec/system/about_page_spec.rb b/spec/system/about_page_spec.rb
@@ -375,25 +375,61 @@
   end
 
   describe "extra groups" do
-    let!(:extra_group) { Fabricate(:group, name: "illuminati") }
+    let!(:extra_groups) do
+      [
+        Fabricate(:group, name: "bananas", created_at: 1.day.ago),
+        Fabricate(:group, name: "apples", created_at: 3.days.ago),
+        Fabricate(:group, name: "oranges", created_at: 2.days.ago),
+      ]
+    end
+    let(:order) { "alphabetically" }
 
     before do
       SiteSetting.about_banner_image = nil
       SiteSetting.show_additional_about_groups = true
       SiteSetting.about_page_extra_groups = extra_groups_setting
+      SiteSetting.about_page_extra_groups_order = order
 
-      extra_group.users << Fabricate(:user)
+      extra_groups.each { |extra_group| extra_group.users << Fabricate(:user) }
     end
 
     context "when extra groups are configured" do
-      let(:extra_groups_setting) { extra_group.id.to_s }
+      let(:extra_groups_setting) { extra_groups.map(&:id).join("|") }
 
-      it "shows the extra groups" do
-        sign_in(admin)
+      context "when groups are set to order alphabetically" do
+        let(:order) { "alphabetically" }
 
-        about_page.visit
+        it "shows the extra groups in alphabetical order" do
+          sign_in(admin)
+
+          about_page.visit
+
+          expect(about_page).to have_css(".about__apples + .about__bananas + .about__oranges")
+        end
+      end
+
+      context "when groups are set to order by creation" do
+        let(:order) { "order of creation" }
+
+        it "shows the extra groups in order of creation" do
+          sign_in(admin)
 
-        expect(about_page).to have_group_with_name("Illuminati")
+          about_page.visit
+
+          expect(about_page).to have_css(".about__bananas + .about__apples + .about__oranges")
+        end
+      end
+
+      context "when groups are set to order by setting selection" do
+        let(:order) { "order of theme setting" }
+
+        it "shows the extra groups in order of selection" do
+          sign_in(admin)
+
+          about_page.visit
+
+          expect(about_page).to have_css(".about__bananas + .about__apples + .about__oranges")
+        end
       end
     end
 
