improvements

davidtaylorhq · davidtaylorhq · commit a5497fe08b2c · 2025-05-21T15:46:37.000+01:00
diff --git a/app/assets/javascripts/discourse/app/components/plugin-connector.js b/app/assets/javascripts/discourse/app/components/plugin-connector.js
@@ -27,7 +27,7 @@ export default class PluginConnector extends Component {
         defineProperty(
           this,
           key,
-          computed("args", function () {
+          computed(`args.${key}`, function () {
             return this.args[key];
           })
         );
diff --git a/app/assets/javascripts/discourse/app/helpers/lazy-hash.js b/app/assets/javascripts/discourse/app/helpers/lazy-hash.js
@@ -1,12 +1,33 @@
 import { setInternalHelperManager } from "@glimmer/manager";
-import { createConstRef } from "@glimmer/reference";
+import { createConstRef, valueForRef } from "@glimmer/reference";
 
 // Like ember's builtin hash helper, but instead of returning a reified object
 // every time its referenced, it returns a static proxy object with auto-trackable keys.
 export default setInternalHelperManager(({ named }) => {
   const proxy = new Proxy(named, {
     get(target, prop) {
-      return target[prop]?.compute();
+      if (target[prop]) {
+        return valueForRef(target[prop]);
+      }
+    },
+    isExtensible() {
+      return false;
+    },
+    getOwnPropertyDescriptor(target, key) {
+      if (key in target) {
+        return {
+          enumerable: true,
+          configurable: true,
+          get() {
+            if (target[key]) {
+              return valueForRef(target[key]);
+            }
+          },
+        };
+      }
+    },
+    set() {
+      return false;
     },
   });
 
