DEV: Add converter & importer for permalink_normalizations

gschlager · gschlager · commit fc9946f595cd · 2025-05-31T22:17:44.000+02:00
diff --git a/migrations/db/intermediate_db_schema/005-permalink_normalizations.sql b/migrations/db/intermediate_db_schema/005-permalink_normalizations.sql
@@ -0,0 +1,4 @@
+CREATE TABLE permalink_normalizations
+(
+  normalization TEXT NOT NULL PRIMARY KEY
+);
diff --git a/migrations/lib/converters/discourse/steps/permalink_normalizations.rb b/migrations/lib/converters/discourse/steps/permalink_normalizations.rb
@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Migrations::Converters::Discourse
+  class PermalinkNormalizations < ::Migrations::Converters::Base::Step
+    attr_accessor :source_db
+
+    def execute
+      normalizations = @source_db.query_value <<~SQL
+        SELECT value
+        FROM site_settings
+        WHERE name = 'permalink_normalizations'
+      SQL
+
+      return if normalizations.blank?
+
+      normalizations
+        .split("|")
+        .each { |normalization| IntermediateDB::PermalinkNormalization.create(normalization:) }
+    end
+  end
+end
diff --git a/migrations/lib/database/intermediate_db/permalink_normalization.rb b/migrations/lib/database/intermediate_db/permalink_normalization.rb
@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module Migrations::Database::IntermediateDB
+  module PermalinkNormalization
+    SQL = <<~SQL
+      INSERT INTO permalink_normalizations (normalization)
+      VALUES (?)
+    SQL
+
+    def self.create(normalization:)
+      ::Migrations::Database::IntermediateDB.insert(SQL, normalization)
+    end
+  end
+end
diff --git a/migrations/lib/importer/steps/permalink_normalizations.rb b/migrations/lib/importer/steps/permalink_normalizations.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Migrations::Importer::Steps
+  class PermalinkNormalizations < ::Migrations::Importer::Step
+    def execute
+      super
+
+      normalizations = SiteSetting.permalink_normalizations
+      normalizations = normalizations.blank? ? [] : normalizations.split("|")
+
+      rows = @intermediate_db.query <<~SQL
+        SELECT normalization
+        FROM permalink_normalizations
+        ORDER BY ROWID
+      SQL
+
+      rows.each do |row|
+        normalization = row[:normalization]
+        normalizations << normalization if normalizations.exclude?(normalization)
+      end
+
+      SiteSetting.permalink_normalizations = normalizations.join("|")
+    end
+  end
+end
diff --git a/migrations/spec/lib/database/intermediate_db/permalink_normalization_spec.rb b/migrations/spec/lib/database/intermediate_db/permalink_normalization_spec.rb
@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+RSpec.describe ::Migrations::Database::IntermediateDB::PermalinkNormalization do
+  it_behaves_like "a database entity"
+end

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +CREATE TABLE permalink_normalizations
 +(
 +  normalization TEXT NOT NULL PRIMARY KEY
 +);