@@ -118,7 +97,6 @@ export default class Results extends Component {
{{! render the first couple suggestions before a search has been performed}}
diff --git a/app/assets/javascripts/discourse/app/components/search-menu/results/assistant-item.gjs b/app/assets/javascripts/discourse/app/components/search-menu/results/assistant-item.gjs
index afe00d52b5be6..7562f92343263 100644
--- a/app/assets/javascripts/discourse/app/components/search-menu/results/assistant-item.gjs
+++ b/app/assets/javascripts/discourse/app/components/search-menu/results/assistant-item.gjs
@@ -23,7 +23,6 @@ export function resetItemSelectCallbacks() {
export default class AssistantItem extends Component {
@service search;
- @service site;
@service appEvents;
icon = this.args.icon || "magnifying-glass";
@@ -135,7 +134,6 @@ export default class AssistantItem extends Component {
{{! template-lint-disable no-pointer-down-event-binding }}
{{! template-lint-disable no-invalid-interactive }}
- {{#each @results as |result index|}}
+ {{#each @results as |result|}}
{{/each}}
{{else if (eq this.suggestionType "categoryOrTag")}}
- {{#each @results as |result index|}}
+ {{#each @results as |result|}}
{{#if result.model}}
{{! render category }}
{{else}}
{{! render tag }}
@@ -174,7 +172,6 @@ export default class Assistant extends Component {
@searchTermChanged={{@searchTermChanged}}
@suggestionKeyword={{@suggestionKeyword}}
@typeClass="tag"
- data-test-assistant-item="result-name-{{index}}"
/>
{{/if}}
{{/each}}
@@ -190,7 +187,6 @@ export default class Assistant extends Component {
@searchTermChanged={{@searchTermChanged}}
@suggestionKeyword={{@suggestionKeyword}}
@typeClass="user"
- data-test-assistant-item="result-user-in-topics-posts"
/>
{{else}}
- {{#each @results as |result index|}}
+ {{#each @results as |result|}}
{{/each}}
{{/if}}
@@ -220,7 +214,7 @@ export default class Assistant extends Component {
@name="search-menu-results-assistant-shortcut-top"
@outletArgs={{hash suggestionShortcuts=this.suggestionShortcuts}}
/>
- {{#each this.suggestionShortcuts as |item index|}}
+ {{#each this.suggestionShortcuts as |item|}}
{{/each}}
{{/if}}
diff --git a/app/assets/javascripts/discourse/app/components/search-menu/results/initial-options.gjs b/app/assets/javascripts/discourse/app/components/search-menu/results/initial-options.gjs
index a1a176329d389..eaa9ca8f3261b 100644
--- a/app/assets/javascripts/discourse/app/components/search-menu/results/initial-options.gjs
+++ b/app/assets/javascripts/discourse/app/components/search-menu/results/initial-options.gjs
@@ -1,7 +1,7 @@
import Component from "@glimmer/component";
import { hash } from "@ember/helper";
import { service } from "@ember/service";
-import { and, not, or } from "truth-helpers";
+import { and, or } from "truth-helpers";
import PluginOutlet from "discourse/components/plugin-outlet";
import { MODIFIER_REGEXP } from "discourse/components/search-menu";
import AssistantItem from "discourse/components/search-menu/results/assistant-item";
@@ -46,10 +46,6 @@ export default class InitialOptions extends Component {
}
}
- get hideForEmptyMobileSearch() {
- return this.args.inHeaderMobileView && !this.search.activeGlobalSearchTerm;
- }
-
get termMatchesContextTypeKeyword() {
return this.search.activeGlobalSearchTerm?.match(MODIFIER_REGEXP);
}
@@ -152,10 +148,7 @@ export default class InitialOptions extends Component {
}
-
- {{#each this.currentUser.recent_searches as |slug index|}}
+ {{#each this.currentUser.recent_searches as |slug|}}