FIX: Allow creating new color palettes based on custom palettes #34351
+315
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35df5eb to
6aa0024
Compare
CvX
reviewed
Aug 15, 2025
app/assets/javascripts/admin/addon/components/admin-config-areas/color-palettes.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/admin/addon/controllers/admin-customize-colors.js
Outdated
Show resolved
Hide resolved
16ae761 to
c89d73d
Compare
This commit: - Modifies color palette selection to work with both base and custom palettes - Updates ID handling for proper palette references - Improves translation fallbacks for color scheme names/descriptions
84ff147 to
ac24092
Compare
ac24092 to
5d152e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
base_scheme_idcolumn from string to integerScreen.Recording.2025-08-19.at.4.16.28.pm.mov