Skip to content

Remove third-party plugins from tests #5817

Open
@jrief

Description

@jrief

The third party apps djangocms-link and djangocms-text-ckeditor require django-cms to be installed. This is intentional and good practice.

However the test-suite for django-cms requires to install djangocms-link and djangocms-text-ckeditor. This adds a circular dependency, which is bad practice and prevents modularity.

Therefore, these tests should either become part of the apps djangocms-link and djangocms-text-ckeditor, or, if that's not possible we should add some mock plugins to emulate their behavior in the django-cms test-suite.

For details look at cms/tests/test_page.py:

...
from djangocms_link.cms_plugins import LinkPlugin
from djangocms_text_ckeditor.cms_plugins import TextPlugin
from djangocms_text_ckeditor.models import Text
...

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions