diff --git a/.github/workflows/test_startcmsproject.yml b/.github/workflows/test_startcmsproject.yml index 0dbaf659924..8638e025a51 100644 --- a/.github/workflows/test_startcmsproject.yml +++ b/.github/workflows/test_startcmsproject.yml @@ -13,7 +13,7 @@ jobs: fail-fast: false matrix: django-version: [ - '4.2', '5.0', + '4.2', '5.0', '5.1' ] python-version: ['3.11'] requirements-file: ['requirements_base.txt'] diff --git a/cms/admin/placeholderadmin.py b/cms/admin/placeholderadmin.py index 1e4acab18ac..e04a4ec3259 100644 --- a/cms/admin/placeholderadmin.py +++ b/cms/admin/placeholderadmin.py @@ -104,9 +104,15 @@ def _get_object_for_single_field(self, object_id, language): # Quick and dirty way to retrieve objects for django-hvad # Cleaner implementation will extend this method in a child mixin try: - return self.model.objects.language(language).get(pk=object_id) + # First see if the model uses the admin manager pattern from cms.models.manager.ContentAdminManager + manager = self.model.admin_manager except AttributeError: - return self.model.objects.get(pk=object_id) + # If not, use the default manager + manager = self.model.objects + try: + return manager.language(language).get(pk=object_id) + except AttributeError: + return manager.get(pk=object_id) def edit_field(self, request, object_id, language): obj = self._get_object_for_single_field(object_id, language) diff --git a/cms/cms_toolbars.py b/cms/cms_toolbars.py index e700e393a48..391e7d45052 100644 --- a/cms/cms_toolbars.py +++ b/cms/cms_toolbars.py @@ -393,7 +393,7 @@ def get_page_content(self): # Toolbar object already set (e.g., in edit or preview mode) return self.obj # Get from db - page_content = self.page.get_content_obj(language=self.current_lang, fallback=False) + page_content = self.page.get_admin_content(language=self.current_lang, fallback=False) return page_content or None def has_page_change_permission(self): diff --git a/cms/models/fields.py b/cms/models/fields.py index 916e85ab0fe..5bcb11485cb 100644 --- a/cms/models/fields.py +++ b/cms/models/fields.py @@ -130,9 +130,6 @@ class Post(models.Model): @cached_property def content(self): return get_placeholder_from_slot(self.placeholders, "content") # A specific placeholder - - - """ default_checks = [] diff --git a/cms/templates/admin/cms/page/plugin/error_form.html b/cms/templates/admin/cms/page/plugin/error_form.html index 89a3937f73a..8e904991e20 100644 --- a/cms/templates/admin/cms/page/plugin/error_form.html +++ b/cms/templates/admin/cms/page/plugin/error_form.html @@ -2,7 +2,7 @@ {% load i18n l10n static %} {% block title %}{% trans "Edit model" %}{% endblock %} - +{% block breadcrumbs %}{% endblock %} {% block content %}