Skip to content

Subresource integrity support? #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
folz opened this issue Feb 1, 2017 · 5 comments
Closed

Subresource integrity support? #103

folz opened this issue Feb 1, 2017 · 5 comments

Comments

@folz
Copy link

folz commented Feb 1, 2017

Is there support for subresource integrity when generating script/link tags? If not, would you be ok with a PR to add support for this?

@mheppner
Copy link

mheppner commented Feb 8, 2017

Could this be implemented directly with django-webpack-loader, or would you have to integrate it with something like webpack-subresource-integrity?

@yourcelf
Copy link

django-webpack-loader could implement this directly by computing the hash of a file when it first loads new stats from webpack-bundle-tracker. It would probably be easier to compute the hash in python rather than relying on another webpack plugin -- webpack-subresource-integrity would require storing and watching yet another json file to get the results of the hash out. The hash result could be cached alongside the filenames, so it wouldn't be a performance drag.

@owais
Copy link
Collaborator

owais commented Apr 8, 2018

I think it's better the support is added to webpack-bundle-tracker or somehow is integrated with a webpack plugin because on Django's side we'll need ability to read bundles (from network), hash them, cache the results, etc. There are plugin that already do this on webpack's side. Being able to leverage existing webpack ecosystem instead of writing python code for every new feature was the biggest motivation behind this project.

If anyone wants to contribute this, let's talk over at https://github.com/owais/webpack-bundle-tracker repo.

@fjsj
Copy link
Member

fjsj commented Jun 10, 2021

Closed via django-webpack/webpack-bundle-tracker#59

@fjsj fjsj closed this as completed Jun 10, 2021
@fjsj
Copy link
Member

fjsj commented Feb 16, 2022

Related: #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants