DictField instances shouldn't be backed by the same dict (issue 101).

djc · djc · commit e582ffee8254 · 2009-12-10T16:49:00.000+01:00
diff --git a/ChangeLog.txt b/ChangeLog.txt
@@ -10,6 +10,8 @@ http://couchdb-python.googlecode.com/hg/?r=default
  * Added a `stats()` method to the `client.Server` class.
  * Added a `tasks()` method to the `client.Server` class.
  * Allow slashes in path components passed to the uri function (issue 96).
+ * `DictField`s now have their own backing dictionary for each instance
+   of their `schema.Document` (issue 101).
 
 
 Version 0.6
diff --git a/couchdb/schema.py b/couchdb/schema.py
@@ -567,7 +567,8 @@ class DictField(Field):
     >>> del server['python-tests']
     """
     def __init__(self, schema=None, name=None, default=None):
-        Field.__init__(self, name=name, default=default or {})
+        default = default or {}
+        Field.__init__(self, name=name, default=lambda: default.copy())
         self.schema = schema
 
     def _to_python(self, value):
diff --git a/couchdb/tests/schema.py b/couchdb/tests/schema.py
@@ -31,6 +31,15 @@ def tearDown(self):
         except client.ResourceNotFound:
             pass
 
+    def test_mutable_fields(self):
+        class Test(schema.Document):
+            d = schema.DictField()
+        a = Test()
+        b = Test()
+        a.d['x'] = True
+        self.assertTrue(a.d.get('x'))
+        self.assertFalse(b.d.get('x'))
+
     def test_automatic_id(self):
         class Post(schema.Document):
             title = schema.TextField()
