Skip to content

Commit c51703b

Browse files
authored
No model for Gradle (GoogleCloudPlatform#344)
1. Remove the model component for Gradle 2. update to latest maven plugin as well.
1 parent e052f90 commit c51703b

File tree

3 files changed

+22
-26
lines changed

3 files changed

+22
-26
lines changed
+15-17
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Copyright 2015 Google Inc. All Rights Reserved.
2-
//
2+
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
55
// You may obtain a copy of the License at
6-
//
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
8-
//
8+
//
99
// Unless required by applicable law or agreed to in writing, software
1010
// distributed under the License is distributed on an "AS IS" BASIS,
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -23,15 +23,15 @@ buildscript { // Configuration for building
2323
}
2424

2525
repositories { // repositories for Jar's you access in your code
26-
maven {
26+
maven {
2727
url 'https://maven-central.storage.googleapis.com' // Google's mirror of Maven Central
28-
// url 'https://oss.sonatype.org/content/repositories/snapshots' // SNAPSHOT Reposiotry (if needed)
28+
// url 'https://oss.sonatype.org/content/repositories/snapshots' // SNAPSHOT Repository (if needed)
2929
}
3030
jcenter()
3131
mavenCentral()
3232
}
3333

34-
apply plugin: 'java' // standard Java tasks
34+
apply plugin: 'java' // standard Java tasks
3535
apply plugin: 'war' // standard Web Archive plugin
3636
apply plugin: 'com.google.cloud.tools.appengine' // App Engine tasks
3737

@@ -43,23 +43,21 @@ dependencies {
4343
}
4444

4545
// [START model]
46-
model {
47-
appengine { // App Engine tasks configuration
48-
run { // local (dev_appserver) configuration (standard environments only)
49-
port = 8080 // default
50-
}
46+
appengine { // App Engine tasks configuration
47+
run { // local (dev_appserver) configuration (standard environments only)
48+
port = 8080 // default
49+
}
5150

52-
deploy { // deploy configuration
53-
stopPreviousVersion = true // default - stop the current version
54-
promote = true // default - & make this the current version
55-
}
51+
deploy { // deploy configuration
52+
stopPreviousVersion = true // default - stop the current version
53+
promote = true // default - & make this the current version
5654
}
5755
}
5856
// [END model]
5957

6058
group = 'com.example.appengine' // Generated output GroupId
6159
version = '1.0-SNAPSHOT' // Version in generated output
6260

63-
sourceCompatibility = JavaVersion.VERSION_1_7 // App Engine Standard uses Java 7
64-
targetCompatibility = JavaVersion.VERSION_1_7 // App Engine Standard uses Java 7
61+
sourceCompatibility = 1.7 // App Engine Standard uses Java 7
62+
targetCompatibility = 1.7 // App Engine Standard uses Java 7
6563
// [END gradle]

appengine/helloworld-new-plugins/pom.xml

+2-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Copyright 2015 Google Inc. All Rights Reserved.
3939
<dependency>
4040
<groupId>javax.servlet</groupId>
4141
<artifactId>servlet-api</artifactId>
42+
<version>2.5</version>
4243
<type>jar</type>
4344
<scope>provided</scope>
4445
</dependency>
@@ -52,7 +53,7 @@ Copyright 2015 Google Inc. All Rights Reserved.
5253
<plugin>
5354
<groupId>com.google.cloud.tools</groupId>
5455
<artifactId>appengine-maven-plugin</artifactId>
55-
<version>0.1.1-beta</version>
56+
<version>0.1.2</version>
5657
<configuration>
5758
<!-- dev appserver configuration (standard environment only) -->
5859
<!--

managed_vms/helloworld/build.gradle

+5-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
// Copyright 2016 Google Inc. All Rights Reserved.
2-
//
2+
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
55
// You may obtain a copy of the License at
6-
//
6+
//
77
// http://www.apache.org/licenses/LICENSE-2.0
8-
//
8+
//
99
// Unless required by applicable law or agreed to in writing, software
1010
// distributed under the License is distributed on an "AS IS" BASIS,
1111
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -49,20 +49,17 @@ gretty {
4949
// [END gretty]
5050

5151
// [START model]
52-
model {
5352
appengine {
54-
5553
deploy { // deploy configuration
5654
stopPreviousVersion = true // default - stop the current version
5755
promote = true // default - & make this the current version
5856
}
5957
}
60-
}
6158
// [END model]
6259

6360
group = 'com.example.appengine' // Generated output GroupId
6461
version = '1.0-SNAPSHOT' // Version in generated output
6562

66-
sourceCompatibility = JavaVersion.VERSION_1_8
67-
targetCompatibility = JavaVersion.VERSION_1_8
63+
sourceCompatibility = 1.8
64+
targetCompatibility = 1.8
6865
// [END gradle]

0 commit comments

Comments
 (0)