cleanup data structures used in Cluster

Nathan Marz · Nathan Marz · commit a10f8bbc236d · 2012-07-25T00:53:39.000-07:00
diff --git a/src/jvm/backtype/storm/scheduler/Cluster.java b/src/jvm/backtype/storm/scheduler/Cluster.java
@@ -84,8 +84,7 @@ public boolean needsScheduling(TopologyDetails topology) {
      * @return
      */
     public Map<ExecutorDetails, String> getNeedsSchedulingExecutorToComponents(TopologyDetails topology) {
-        Collection<ExecutorDetails> allExecutors = new ArrayList<ExecutorDetails>();
-        allExecutors.addAll(topology.getExecutors());
+        Collection<ExecutorDetails> allExecutors = new HashSet(topology.getExecutors());
         
         SchedulerAssignment assignment = this.assignments.get(topology.getId());
         if (assignment != null) {
@@ -175,13 +174,12 @@ public List<WorkerSlot> getAvailableSlots(SupervisorDetails supervisor) {
     /**
      * get the unassigned executors of the topology.
      */
-    public List<ExecutorDetails> getUnassignedExecutors(TopologyDetails topology) {
+    public Collection<ExecutorDetails> getUnassignedExecutors(TopologyDetails topology) {
         if (topology == null) {
             return new ArrayList<ExecutorDetails>(0);
         }
 
-        List<ExecutorDetails> ret = new ArrayList<ExecutorDetails>();
-        ret.addAll(topology.getExecutors());
+        Collection<ExecutorDetails> ret = new HashSet(topology.getExecutors());
         
         SchedulerAssignment assignment = this.getAssignmentById(topology.getId());
         if (assignment != null) {
